Page MenuHomePhabricator

parser tests should reset service locator
Closed, ResolvedPublic

Description

MediaWikiTestCase was recently changed to reset the MediaWIkiServices service locator between all tests. The same should be done for parser test, to isolate parser tests against other test cases. When parser tests are run via PHPUnit, ParserTestTopLevelSuite would be responsible for that. Stand-alone runs via parserTests.php would use ParserTestRunner::runTestsFromFiles

Event Timeline

daniel created this task.Sep 11 2018, 5:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 11 2018, 5:04 PM

Change 459820 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Reset services in ParserTestTopLevelSuite.

https://gerrit.wikimedia.org/r/459820

daniel renamed this task from ParserTestCase should reset service locator to parser tests should reset service locator.Sep 12 2018, 1:56 PM
daniel updated the task description. (Show Details)

Change 459820 merged by jenkins-bot:
[mediawiki/core@master] Reset services in ParserTestTopLevelSuite.

https://gerrit.wikimedia.org/r/459820