Maniphest T204107

UserMerge is missing messages for log entries
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daimona
	Sep 12 2018, 9:18 AM

Description

UserMerge has two logs: mergeuser and deleteuser. However, the needed messages (logentry-usermerge-deleteuser and logentry-usermerge-mergeuser) aren't defined. See for instance this link. I'd add the messages myself but I don't know this extension at all.

Details

Project	Branch	Lines +/-	Subject
mediawiki/extensions/UserMerge	master	+94 -34	Migrate UserMerge to modern logging system
mediawiki/extensions/UserMerge	REL1_32	+94 -34	Migrate UserMerge to modern logging system
mediawiki/extensions/UserMerge	master	+4 -4	Add logentry i18n messages for merge and deleteuser

Customize query in gerrit

Related Objects

Mentioned In: T211390: System message "Logentry-usermerge-deleteuser" is missing
Mentioned Here: rEUMEceceb6fe739f: Localisation updates from https://translatewiki.net.
rEUME8e3e639c4a38: Localisation updates from https://translatewiki.net.

Event Timeline

Daimona created this task.Sep 12 2018, 9:18 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2018, 9:18 AM

Liuxinyu970226 added a subscriber: Liuxinyu970226.Sep 12 2018, 11:02 AM

Found this issue, too, I'll add these messages in a patch and upload it in a second :)

Change 460764 had a related patch set uploaded (by Florianschmidtwelzow; owner: Florianschmidtwelzow):
[mediawiki/extensions/UserMerge@master] Add logentry i18n messages for merge and deleteuser

https://gerrit.wikimedia.org/r/460764

gerritbot added a project: Patch-For-Review.Sep 16 2018, 6:44 PM

I made two (one, two) changes that might be related to this. @Florian Shall we also update the extension.json file where both log keys are defined as well? Thanks.

Change 461292 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/UserMerge@master] Migrate UserMerge to modern logging system

https://gerrit.wikimedia.org/r/461292

• PlavorSeol added a subscriber: • PlavorSeol.Dec 6 2018, 5:12 PM

This comment was removed by • PlavorSeol.

MarcoAurelio mentioned this in T211390: System message "Logentry-usermerge-deleteuser" is missing.Dec 7 2018, 10:31 AM

Kghbln merged a task: T211390: System message "Logentry-usermerge-deleteuser" is missing.Dec 7 2018, 12:10 PM

Kghbln added a subscriber: Kghbln.

Change 461292 merged by jenkins-bot:
[mediawiki/extensions/UserMerge@master] Migrate UserMerge to modern logging system

https://gerrit.wikimedia.org/r/461292

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.12; 2019-01-08).Dec 28 2018, 8:01 AM

Hi @Kghbln - Does the patch merged above addresses the issue? Is it possible for you to test it? Best regards.

<s>No, unfortunately not. After upgrading to latest master from ceceb6f... to 8e3e639... the system message still does not show. See the log.</s>

Indeed, it does fix the issue. Thanks!

Kghbln closed this task as Resolved.Jan 2 2019, 6:21 PM

Daimona removed a project: Patch-For-Review.Jan 2 2019, 6:25 PM

MarcoAurelio awarded a token.Jan 2 2019, 6:34 PM

Change 460764 abandoned by Matěj Suchánek:
Add logentry i18n messages for merge and deleteuser

Reason:
Reworked in Ia17d099711d73cf2a1075e1f758fdd1271b02979

https://gerrit.wikimedia.org/r/460764

matej_suchanek claimed this task.Jan 5 2019, 10:29 AM

• PlavorSeol removed a subscriber: • PlavorSeol.Jan 11 2019, 6:35 PM

Change 484025 had a related patch set uploaded (by Paladox; owner: Matěj Suchánek):
[mediawiki/extensions/UserMerge@REL1_32] Migrate UserMerge to modern logging system

https://gerrit.wikimedia.org/r/484025

gerritbot added a project: Patch-For-Review.Jan 13 2019, 6:55 PM

Change 484025 merged by jenkins-bot:
[mediawiki/extensions/UserMerge@REL1_32] Migrate UserMerge to modern logging system

https://gerrit.wikimedia.org/r/484025

MarcoAurelio removed a project: Patch-For-Review.Jan 15 2019, 10:42 AM

Liuxinyu970226 removed a subscriber: Liuxinyu970226.Jan 16 2019, 1:33 AM