Page MenuHomePhabricator

Add favicon to icinga and tendril
Closed, ResolvedPublic

Description

Of the wikimedia sites I mostly use, tendril and icinga are lacking favicon, which allows for a quick identification when one has hundreds of tabs open in a browser. This limits accesibility and speed of operation:

Screenshot_20180830_160224.png (26×441 px, 5 KB)

This has 2 steps- create or find a free icon suitable to represent these 2 service (note tendril is at EOL, so anything generic would do) and research the best way to implement those (app code changes, static serving, custom apache redirects, ...)

Event Timeline

jcrespo triaged this task as Lowest priority.Sep 12 2018, 9:45 AM
Addshore renamed this task from Add favicon to icinga an tendril to Add favicon to icinga and tendril.Sep 12 2018, 12:53 PM

Icinga is now showing me an icon, but etherpad isn't. Not sure how much of this is valid or it is my browser cache misbehaving.

Icinga is now showing a favicon. Only tendril is left!

Change 583203 had a related patch set uploaded (by Privacybatm; owner: Privacybatm):
[operations/software/tendril@master] Add favicon to Tendril

https://gerrit.wikimedia.org/r/583203

tendril_favicon.png (719×1 px, 84 KB)

This patch is tested for 404-page only!

Thank you very much for your contribution. I have left a comment on the change. In order for you to not lose much time, I have left a transparent .ico file here: (you can use it or create it on your own, doesn't matter, the icon itself is not important)

jcrespo moved this task from Triage to In progress on the DBA board.

Change 583203 merged by Jcrespo:
[operations/software/tendril@master] Add favicon to Tendril

https://gerrit.wikimedia.org/r/583203

The work is completed after we deployed the change to production:

Screenshot_20200325_123958.png (562×910 px, 86 KB)

Thank you very much @Privacybatm for your contribution.

There is a small bug, in which favicon.ico is references as being in the current dir. When we are under a hierarchy (such as https://tendril.wikimedia.org/host/view/db1074.eqiad.wmnet/3306), the icon 404s. The icon requires an absolute path from root dir, like js is.

Change 586358 had a related patch set uploaded (by Jcrespo; owner: Jcrespo):
[operations/software/tendril@master] tendril: Fix relative reference to favicon when not on root

https://gerrit.wikimedia.org/r/586358

Change 586358 merged by Jcrespo:
[operations/software/tendril@master] tendril: Fix relative reference to favicon when not on root

https://gerrit.wikimedia.org/r/586358

Above url works now