Page MenuHomePhabricator

Missing file revisions should be handled gracefully (delete, move, etc).
Closed, ResolvedPublic

Description

Author: herd

Description:

Move

Per https://bugzilla.wikimedia.org/show_bug.cgi?id=15842#c8 image pages were being moved while the associated files were not, in the case of missing old revisions. Vasilvv has fixed this to abort on error, but file moves should gracefully skip missing old revisions when moving, rather than simply fail.

Delete

If you delete an image or old version of an image where the associated file is missing, you cannot undelete the image, except by manually de-selecting all broken old versions from the file history.

Deleting old missing revisions results in a successful removal of the row with warning:
Error deleting file: Could not rename file "public/archive/a/a3/20080704135833!AnyNonsense.png" to "deleted/7/g/q/7gqsst5kfvsixebqpajrsf31hczook9.png".

Attempting to undelete a single missing revision results in general errors:
Undelete failed; someone else may have undeleted the page first.
Undeletion will not be performed if it will result in the top page or file revision being partially deleted. In such cases, you must uncheck or unhide the newest deleted revision.
Error undeleting file: Could not find file "deleted/7/g/q/7gqsst5kfvsixebqpajrsf31hczook9.png".

Attempting to undelete all revisions where one or more versions are missing results in a success message with warnings, and a corrupted page created with no files associated at all (similar to earlier file moving problems):

Errors were encountered while undeleting the file:
  * Could not find file "deleted/b/x/i/bxik35jpaakpwc8a6i09gq3heevjl0e.png".
  * Could not find file "deleted/7/g/q/7gqsst5kfvsixebqpajrsf31hczook9.png".

Version: 1.15.x
Severity: normal

Details

Reference
bz18420

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:33 PM
bzimport set Reference to bz18420.
vvv added a comment.Apr 26 2009, 12:37 PM

Fixed in r49896.

Gilles moved this task from Untriaged to Done on the Multimedia board.