Page MenuHomePhabricator

Sorting by user name on Special:AbuseFilter/history doesn't work
Closed, ResolvedPublic


Go to Special:AbuseFilter/history and click "User" to make the table sorted by user. The page is refreshed and the url is updated with sort=afh_user_text but nothing changes, the table is still sorted by timestamp. Now click "User" again and the order is changed from descending to ascending but it's still sorted by timestamp.

Per @Anomie's comment on, this sorting would turn out to be very slow (if it worked) during the field's migration (T188180), so I removed it. This task should track the removal and thoughts on reimplementing (if possible or necessary).

Event Timeline

I don't see it that useful, i.e. it's only worth it if we can reimplement it with minimal effort. As for the reason it isn't working, looking at queries I can see that it is indeed ordered by afh_timestamp. I suspect a bug inside TablePager, or maybe we're just doing something weird with it.

UDPATE: This happens because we override getIndexField, which in turn is always used when sorting. I'm not sure why we do that, but removing it the sort is performed correctly. This doesn't mean that we want to keep the feature, though.

Change 633190 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/AbuseFilter@master] Remove sorting by user from Special:AbuseFilter/history

Change 633190 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Remove sorting by user from Special:AbuseFilter/history