Maniphest T204210

Sorting by user name on Special:AbuseFilter/history doesn't work
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matej_suchanek
	Sep 13 2018, 11:33 AM

Description

Go to Special:AbuseFilter/history and click "User" to make the table sorted by user. The page is refreshed and the url is updated with sort=afh_user_text but nothing changes, the table is still sorted by timestamp. Now click "User" again and the order is changed from descending to ascending but it's still sorted by timestamp.

Per @Anomie's comment on https://gerrit.wikimedia.org/r/#/q/Ic755526d5f989c4a66b1d37527cda235f61cb437, this sorting would turn out to be very slow (if it worked) during the field's migration (T188180), so I removed it. This task should track the removal and thoughts on reimplementing (if possible or necessary).

Details

	Subject	Repo	Branch	Lines +/-
	Remove sorting by user from Special:AbuseFilter/history	mediawiki/extensions/AbuseFilter	master	+1 -9

Customize query in gerrit

Related Objects

Mentioned In: T264948: Prohibit use of 'object' as type in docblocks
Mentioned Here: T188180: Read from and write to `actor` table in AbuseFilter

Event Timeline

matej_suchanek created this task.Sep 13 2018, 11:33 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2018, 11:33 AM

I don't see it that useful, i.e. it's only worth it if we can reimplement it with minimal effort. As for the reason it isn't working, looking at queries I can see that it is indeed ordered by afh_timestamp. I suspect a bug inside TablePager, or maybe we're just doing something weird with it.

UDPATE: This happens because we override getIndexField, which in turn is always used when sorting. I'm not sure why we do that, but removing it the sort is performed correctly. This doesn't mean that we want to keep the feature, though.

Change 633190 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/AbuseFilter@master] Remove sorting by user from Special:AbuseFilter/history

https://gerrit.wikimedia.org/r/633190

gerritbot added a project: Patch-For-Review.Oct 9 2020, 1:55 PM

Daimona mentioned this in T264948: Prohibit use of 'object' as type in docblocks.Oct 9 2020, 4:38 PM

Change 633190 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Remove sorting by user from Special:AbuseFilter/history

https://gerrit.wikimedia.org/r/633190

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.13; 2020-10-12).Oct 10 2020, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 10 2020, 12:10 PM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:01 PM

matej_suchanek closed this task as Resolved.Oct 28 2020, 9:23 AM

matej_suchanek claimed this task.