Page MenuHomePhabricator

Variables inside wgAbuseFilterVariables (available via JS) have old names for old entries
Open, Needs TriagePublic

Description

When viewing the details of an old AbuseLog entries, if you look at the content of wgAbuseFilterVariables in the JS console you'll notice that variables still have the old names: article_text etc. For new entries (after the introduction of new variables), new names are used. I guess this is because wgAbuseFilterVariables is generated when recording the hit, so it's obvious that it has old names. For this reason, I wouldn't advice changing them in the DB. However, we should probably map them to the new names on the fly before adding them to the page.

Details

Related Gerrit Patches:
mediawiki/extensions/AbuseFilter : masterAdd a maintenance script to clean afl_var_dump

Event Timeline

Daimona created this task.Sep 13 2018, 12:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2018, 12:54 PM

If we decide to change old dumps as part of T204236, this would be automatically fixed.

Daimona moved this task from Backlog to Future on the User-Daimona board.

Change 482499 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Add a maintenance script to clean afl_var_dump

https://gerrit.wikimedia.org/r/482499

Daimona claimed this task.Jan 9 2019, 12:00 PM
Daimona moved this task from Future to Under review on the User-Daimona board.

Change 482499 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] [WIP] Add a maintenance script to clean afl_var_dump

https://gerrit.wikimedia.org/r/482499