Page MenuHomePhabricator
Create Task
Maniphest T204260

Consolidate svgmin config and svg / grunt-svgmin checker
Open, MediumPublic
Actions

Description

MobileFrontend, MinervaNeue, and Popups each contain approximately the same lengthy svgmin config and script or Gruntfile. This task encompasses the work to consolidate and move the config and the checker script to a new repo under wikimedia and publish a new NPM package under @wikimedia and replace the duplicate code in MobileFrontend, MinervaNeue, and Popups (don't forget to uninstall the grunt-svgmin package). The new checker should be invoked as a pre-commit hook. This task will also involve re-reading the svgmin configuration documentation to have reasonable due diligence that our configuration and usage are up to date.

See also:

Related Objects

Event Timeline

• Niedzielski created this task.Sep 13 2018, 4:01 PM
Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptSep 13 2018, 4:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Niedzielski updated the task description. (Show Details)Sep 13 2018, 4:16 PM
• Niedzielski added subscribers: Volker_E, Jdlrobson.
Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Sep 13 2018, 4:21 PM
Jdlrobson mentioned this in T202743: Add precommit tests to MobileFrontend repositories.Sep 13 2018, 6:16 PM
Jdlrobson added a comment.EditedSep 18 2018, 11:50 PM

How does this relate to the work @Volker_E did (and T178867)?

Jdlrobson added a project: Front-end-Standards-Group.Sep 18 2018, 11:52 PM

I'm keen to hear if there is a standard way to do this.^

Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.Sep 26 2018, 10:01 PM

Hopefully we can discuss this in a future frontends session..

Jdlrobson moved this task from Inbox to Nominated (next meeting) on the Front-end-Standards-Group board.Sep 26 2018, 10:02 PM
Volker_E moved this task from Nominated (next meeting) to Inbox on the Front-end-Standards-Group board.Dec 11 2019, 12:44 AM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptDec 11 2019, 12:44 AM
Jdlrobson moved this task from Backlog to Tech debt on the MinervaNeue board.Jan 17 2020, 10:22 PM
Jdlrobson moved this task from Tech debt to Blocked on Discussion on the MinervaNeue board.Jan 17 2020, 10:51 PM
• Demian mentioned this in T246321: [EPIC] Transition Gruntfile.js tasks to NPM scripts in some projects.Feb 27 2020, 9:18 AM
• Demian mentioned this in T246326: Process template: How to transition Gruntfile.js tasks to NPM scripts.Feb 27 2020, 9:38 AM
Jdlrobson renamed this task from Consolidate svgmin config and checker to Consolidate svgmin config and svg / grunt-svgmin checker.Mar 3 2020, 6:58 PM
Jdlrobson merged a task: T179361: Move MobileFrontend/Minerva's svg_check.sh script into a reusable, separate library.
Jdlrobson added subscribers: Legoktm, Jdforrester-WMF.
Jdlrobson moved this task from Backlog to Team: web on the MobileFrontend board.Jul 24 2020, 3:01 PM
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Tracking).
ovasileva moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.Sep 1 2020, 4:04 PM
Jdlrobson assigned this task to ovasileva.Mar 3 2021, 10:04 PM
Jdlrobson moved this task from Triaged but Future to Needs Prioritization on the Web-Team-Backlog board.
Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.Mar 3 2021, 10:07 PM
Volker_E mentioned this in T280923: Enforce check for uncompressed SVG files in Popups CI.Apr 22 2021, 6:38 PM
Volker_E added a subscriber: Jdrewniak.Apr 30 2021, 12:10 PM

From @Jdrewniak on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/682017:

I'd prefer a solution written in Node.js and the SVGO JS api (an additional benefit being the ability to loop through files asynchronously), offering the best cross-OS compatibility. That being said, I don't think the creation of such a library should be a blocker here.

Volker_E added a comment.Apr 30 2021, 12:14 PM

This should be split up into two tasks:

  1. A Wikimedia specific SVGO config, since v2.n possible as JS based config as dependency
  2. A Wikimedia svg_check as dependency for linting
  1. SVGO and svg_check (or similar) use centralized config
Jdlrobson moved this task from Triaged but Future to Needs Prioritization on the Web-Team-Backlog board.Apr 30 2021, 9:16 PM
Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.Jun 2 2021, 8:18 PM
Jdlrobson moved this task from Blocked on Discussion to Blocked on the MinervaNeue board.Jul 21 2021, 7:27 PM
Jdlrobson moved this task from Triaged but Future to Tracking on the Web-Team-Backlog board.Jul 26 2021, 8:52 PM
Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.
Jdlrobson moved this task from Blocked to Tracking on the MinervaNeue board.Sep 3 2021, 5:12 PM
Jdlrobson edited projects, added MinervaNeue (Tracking); removed MinervaNeue.
Jdlrobson edited projects, added Page-Previews (Tracking); removed Web-Team-Backlog (Tracking), Page-Previews, MobileFrontend.Sep 7 2021, 9:12 PM
Aklapper removed ovasileva as the assignee of this task.Nov 21 2023, 8:20 AM
Aklapper added a subscriber: ovasileva.

@ovasileva: Per emails from Sep18 and Oct20 and https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup , I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action... → Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL