Maniphest T204269

Create unit tests for Reading lists API classes
Closed, ResolvedPublic
Actions

Description

From parent T184544: [EPIC] Write integration tests for ReadingLists extension

The internals of ReadingLists have good unit test coverage, but the API classes have no tests. Even though their functionality is fairly simple, that should eventually be fixed.

https://doc.wikimedia.org/cover-extensions/ReadingLists/src/Api/index.html

Details

	Subject	Repo	Branch	Lines +/-
	Fixing cover tags	mediawiki/extensions/ReadingLists	master	+2 -2
	Unit tests for Api ReadingLists	mediawiki/extensions/ReadingLists	master	+1 K -123

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T184544 [EPIC] Write integration tests for ReadingLists extension
		Resolved		MSantos	T204269 Create unit tests for Reading lists API classes

Event Timeline

MSantos created this task.Sep 13 2018, 6:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2018, 6:15 PM

MSantos added a parent task: T184544: [EPIC] Write integration tests for ReadingLists extension.Sep 13 2018, 6:16 PM

MSantos triaged this task as Medium priority.Sep 13 2018, 6:21 PM

MSantos updated the task description. (Show Details)

MSantos claimed this task.Sep 28 2018, 5:35 PM

MSantos moved this task from To Do to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

Change 458494 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/extensions/ReadingLists@master] Unit tests for Api ReadingLists

https://gerrit.wikimedia.org/r/458494

gerritbot added a project: Patch-For-Review.Sep 28 2018, 5:40 PM

MSantos mentioned this in rERLS1e86619be9d6: Unit tests for Api ReadingLists.Sep 28 2018, 5:44 PM

Change 458494 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@master] Unit tests for Api ReadingLists

https://gerrit.wikimedia.org/r/458494

• Mholloway moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Oct 2 2018, 11:27 AM

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)).Oct 2 2018, 12:00 PM

MSantos moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Oct 4 2018, 8:18 PM

Change 464712 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/extensions/ReadingLists@master] Fixing cover tags

https://gerrit.wikimedia.org/r/464712

Before sign-off, I realized there were some wrong cover tags. Just a minor nit, still feel free to keep this task open if you think it should wait until next deployment.

MSantos mentioned this in rERLS6a6c4ad65efa: Fixing cover tags.Oct 4 2018, 8:37 PM

Change 464712 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@master] Fixing cover tags

https://gerrit.wikimedia.org/r/464712

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)); removed MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)).Oct 5 2018, 10:00 AM