Page MenuHomePhabricator

Create unit tests for Reading lists API classes
Closed, ResolvedPublic

Description

From parent T184544: [EPIC] Write integration tests for ReadingLists extension

The internals of ReadingLists have good unit test coverage, but the API classes have no tests. Even though their functionality is fairly simple, that should eventually be fixed.

https://doc.wikimedia.org/cover-extensions/ReadingLists/src/Api/index.html

Event Timeline

MSantos created this task.Sep 13 2018, 6:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2018, 6:15 PM
MSantos triaged this task as Medium priority.Sep 13 2018, 6:21 PM
MSantos updated the task description. (Show Details)

Change 458494 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/extensions/ReadingLists@master] Unit tests for Api ReadingLists

https://gerrit.wikimedia.org/r/458494

Change 458494 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@master] Unit tests for Api ReadingLists

https://gerrit.wikimedia.org/r/458494

Change 464712 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/extensions/ReadingLists@master] Fixing cover tags

https://gerrit.wikimedia.org/r/464712

Before sign-off, I realized there were some wrong cover tags. Just a minor nit, still feel free to keep this task open if you think it should wait until next deployment.

Change 464712 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@master] Fixing cover tags

https://gerrit.wikimedia.org/r/464712

The ReadingList API has now 65.75% of coverage. @Tgr and @Jhernandez any thoughts or can we mark it as resolved?

I'll leave it to @Tgr to decide, whatever you both think works.

Tgr closed this task as Resolved.Nov 19 2018, 5:45 PM

Thanks @MSantos!