Page MenuHomePhabricator
Create Task
Maniphest T204270

Create unit tests for Reading Lists core classes
Closed, ResolvedPublic
Actions

Description

From parent T184544: [EPIC] Write integration tests for ReadingLists extension:

From the coverage's dashboard is also possible to see that some core classes need unit tests too.

https://doc.wikimedia.org/cover-extensions/ReadingLists/src/index.html

  • HookHandler (0%) (Not really testable)
  • ReverseInterwikiLookup (0%)
  • Utils.php (57.69%)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/ReadingListsmaster+14 -2Improve core classes unit testing
Customize query in gerrit

Related Objects
Search...

Event Timeline

MSantos created this task.Sep 13 2018, 6:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2018, 6:21 PM
MSantos added a parent task: T184544: [EPIC] Write integration tests for ReadingLists extension.Sep 13 2018, 6:21 PM
MSantos updated the task description. (Show Details)Sep 13 2018, 6:24 PM
MSantos claimed this task.Nov 20 2018, 5:21 PM
MSantos triaged this task as Medium priority.
MSantos mentioned this in T184544: [EPIC] Write integration tests for ReadingLists extension.Nov 28 2018, 8:55 PM
• Tgr added a subscriber: • Tgr.Dec 1 2018, 3:07 AM

ReverseInterwikiLookup and Utils::getDeletedExpiry could probably use some tests, the rest is not really testable.

MSantos moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.Dec 12 2018, 10:15 PM
gerritbot added a subscriber: gerritbot.Dec 13 2018, 12:08 AM

Change 479357 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/extensions/ReadingLists@master] Improve core classes unit testing

https://gerrit.wikimedia.org/r/479357

gerritbot added a project: Patch-For-Review.Dec 13 2018, 12:08 AM
MSantos moved this task from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.Dec 13 2018, 12:09 AM
MSantos mentioned this in rERLSe843d28382ee: Improve core classes unit testing.Dec 13 2018, 12:22 AM
MSantos mentioned this in rERLS95e88fa5d2f3: Improve core classes unit testing.Dec 13 2018, 5:00 PM
MSantos mentioned this in rERLS84ce12a28734: Improve core classes unit testing.Dec 14 2018, 11:31 PM
gerritbot added a comment.Dec 17 2018, 4:20 AM

Change 479357 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@master] Improve core classes unit testing

https://gerrit.wikimedia.org/r/479357

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Dec 17 2018, 5:00 AM
MSantos moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog (Kanban) board.Dec 17 2018, 2:20 PM
MSantos moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog (Kanban) board.
MSantos removed a project: Patch-For-Review.Feb 7 2019, 6:15 PM
MSantos closed this task as Resolved.Feb 7 2019, 6:21 PM
MSantos updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL