Page MenuHomePhabricator
Create Task
Maniphest T204278

Use un-polyfills in mediawiki/vendor
Closed, ResolvedPublic
Actions

Description

We have ctype and mbstring polyfills in mediawiki/vendor because symfony depends upon them, but they're dead code because we always have the PHP extensions installed (and MediaWiki core enforces that). We can use https://github.com/BackEndTea/un-poly-all to get rid of them.

Details

SubjectRepoBranchLines +/-
Replace symfony/polyfill-* with backendtea/un-poly-*mediawiki/vendormaster+105 -3 K
Customize query in gerrit

Event Timeline

Legoktm created this task.Sep 13 2018, 8:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2018, 8:21 PM
gerritbot subscribed.Sep 14 2018, 1:04 AM

Change 460464 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@master] Replace symfony/polyfill-* with backendtea/un-poly-all

https://gerrit.wikimedia.org/r/460464

gerritbot added a project: Patch-For-Review.Sep 14 2018, 1:04 AM
Reedy subscribed.Sep 14 2018, 1:07 AM

Certainly looks a lot neater in terms of PHP files. Adds quite a lot to the json files, but own't be much churn on it

gerritbot added a comment.Sep 14 2018, 1:41 AM

Change 460464 merged by jenkins-bot:
[mediawiki/vendor@master] Replace symfony/polyfill-* with backendtea/un-poly-*

https://gerrit.wikimedia.org/r/460464

Reedy removed a project: Patch-For-Review.Sep 14 2018, 1:53 AM
Krinkle awarded a token.Sep 14 2018, 2:32 AM
Legoktm closed this task as Resolved.Sep 14 2018, 5:42 AM
Legoktm assigned this task to Reedy.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL