Page MenuHomePhabricator

Tweak HTML for preview bar (patch)
Closed, ResolvedPublic



patch against r49247

Currently it's difficult to effectively customise the appearance of the notice that displays when previewing a page; the h2 "preview" header (and the "previewconflict" header when it appears) is unidentified and appears outside the <div class="previewnote"> that contains the "remember this is only a preview" message. Changes in this patch:

  1. assign IDs for both h2s so they can be identified individually
  2. move both <h2>s inside the "previewnote" div so it forms a clearer semantic grouping; move the "text-indent:3em" CSS rule to the inner <p> so it doesn't screw up the h2 indentation
  3. use an <hr> instead of a bottom margin; semantically clearer and probably better from an accessibility PoV.

Version: 1.15.x
Severity: enhancement

attachment diff.txt ignored as obsolete



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:35 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz18438.
bzimport added a subscriber: Unknown Object (MLST). wrote:

Updated patch, against r49247

Better patch: previous one was duplicated for some reason (not sure if it would have applied or not), and I forgot to bump $wgStyleVersion.


(In reply to comment #1)

Created an attachment (id=6033) [details]

Never, ever add BOMs... (as is in this patch for trunk/phase3/includes/DefaultSettings.php)

Applied with tweaks in r50702 ($this->isConflict NOT $this->isConflict()!). Please test your patches. wrote:

I think this one was from before I got my test wiki off the ground.


(In reply to comment #4)

I think this one was from before I got my test wiki off the ground.

BOM?? wrote:


So *that's* why the diff marked those lines. Stupid Windows Notepad...