Page MenuHomePhabricator
Create Task
Maniphest T204488

Wikibase\MediaInfo\DataModel\MediaInfo must implement method `clear`
Closed, ResolvedPublic
Actions

Description

Outdated

MediaInfo is currently on wikibase/data-model 7.3.0, but if/when we upgrade, we're going to have to implement function clear, which is now part of interface EntityDocument (or interface Clearable, actually)

See https://github.com/wmde/WikibaseDataModel/commit/ec1d98abc8f6fd3e255c93689954cd43316ce46a

Details

SubjectRepoBranchLines +/-
Remove clear() method as it's not usedmediawiki/extensions/WikibaseMediaInfomaster+0 -6
Implemented clear() method in MediaInfo classmediawiki/extensions/WikibaseMediaInfomaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

matthiasmullie created this task.Sep 17 2018, 10:14 AM
Restricted Application added a project: Multimedia. · View Herald TranscriptSep 17 2018, 10:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore added a project: [DEPRECATED] wdwb-tech.Sep 17 2018, 12:37 PM
Addshore moved this task from Inbox to Blocked on the [DEPRECATED] wdwb-tech board.
gerritbot subscribed.Sep 17 2018, 1:41 PM

Change 460903 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Implemented clear() method in MediaInfo class

https://gerrit.wikimedia.org/r/460903

gerritbot added a project: Patch-For-Review.Sep 17 2018, 1:41 PM
Cparle mentioned this in rEWBI5f5a7a0856aa: Implemented clear() method in MediaInfo class.Sep 17 2018, 1:42 PM
gerritbot added a comment.Sep 17 2018, 2:26 PM

Change 460903 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Implemented clear() method in MediaInfo class

https://gerrit.wikimedia.org/r/460903

Cparle moved this task from To Do to Doing on the Multimedia-Team-Working-Board board.Sep 17 2018, 4:18 PM
Cparle moved this task from Doing to Code Review on the Multimedia-Team-Working-Board board.
Cparle moved this task from Code Review to Ready for Production Testing on the Multimedia-Team-Working-Board board.
Addshore moved this task from Blocked to Active on the [DEPRECATED] wdwb-tech board.Oct 8 2018, 12:43 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptOct 8 2018, 12:43 PM
Addshore added a project: MediaWiki-Vendor.Oct 31 2018, 4:42 PM
Addshore removed a project: Patch-For-Review.Jan 18 2019, 1:18 PM
Addshore updated the task description. (Show Details)
Addshore subscribed.

So, the situation here changed and datamodel changed to avoid the breaking change.
MediaInfo now uses 9.x, but the MediaInfo entity does have a clear method, (that may not be used?), and also the entity does not implement ClearableEntity.

Either:

  • The clear method should be removed if it is not used.
  • MediaInfo entity should implement the ClearableEntity interface.
Addshore moved this task from incoming to monitoring on the Wikidata board.Feb 11 2019, 9:07 AM
Addshore triaged this task as Low priority.Jun 22 2019, 10:00 PM
Addshore added a subscriber: Cparle.

Poke to @Cparle
This task is probably easily fixable or closable :)

Cparle edited projects, added Structured-Data-Team-Current-Work; removed Multimedia-Team-Working-Board.Jun 27 2019, 2:22 PM
gerritbot added a comment.Jul 3 2019, 2:18 PM

Change 520453 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Remove clear() method as it's not used

https://gerrit.wikimedia.org/r/520453

gerritbot added a project: Patch-For-Review.Jul 3 2019, 2:18 PM
Cparle claimed this task.Jul 3 2019, 2:18 PM
Cparle moved this task from To Do to Doing on the Structured-Data-Team-Current-Work board.
Cparle moved this task from Doing to Code Review on the Structured-Data-Team-Current-Work board.
gerritbot added a comment.Jul 3 2019, 3:13 PM

Change 520453 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Remove clear() method as it's not used

https://gerrit.wikimedia.org/r/520453

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jul 3 2019, 4:00 PM
gerritbot added a comment.Jul 4 2019, 11:50 AM

Change 520734 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Use regex to replace commas in quantity value

https://gerrit.wikimedia.org/r/520734

Cparle closed this task as Resolved.Jul 4 2019, 11:56 AM
LucasWerkmeister mentioned this in T233522: Cannot clear MediaInfo entities.Sep 22 2019, 3:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL