Maniphest T204577

JsonConfig emits PHP error "Cannot access property on non-object" in JCApi::addStatusConf
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Krinkle
	Sep 17 2018, 6:34 PM

Description

Error

Request ID: W5-vPArAIFoAAGhDdHIAAABF

message

PHP Notice: Cannot access property on non-object

There are close variations of this error from the same method but different line numbers.

JCApi.php:32 Trace

#0 /srv/mediawiki/php-1.32.0-wmf.20/extensions/JsonConfig/includes/JCApi.php(32): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.32.0-wmf.20/extensions/JsonConfig/includes/JCApi.php(64): JsonConfig\JCApi::addStatusConf(stdClass)
#2 /srv/mediawiki/php-1.32.0-wmf.20/includes/api/ApiMain.php(1587): JsonConfig\JCApi->execute()
#3 /srv/mediawiki/php-1.32.0-wmf.20/includes/api/ApiMain.php(531): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.32.0-wmf.20/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.32.0-wmf.20/api.php(87): ApiMain->execute()
#6 /srv/mediawiki/w/api.php(3): include(string)

JCApi.php:33 Trace

#0 /srv/mediawiki/php-1.32.0-wmf.20/extensions/JsonConfig/includes/JCApi.php(33): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.32.0-wmf.20/extensions/JsonConfig/includes/JCApi.php(64): JsonConfig\JCApi::addStatusConf(stdClass)
#2 /srv/mediawiki/php-1.32.0-wmf.20/includes/api/ApiMain.php(1587): JsonConfig\JCApi->execute()
#3 /srv/mediawiki/php-1.32.0-wmf.20/includes/api/ApiMain.php(531): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.32.0-wmf.20/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.32.0-wmf.20/api.php(87): ApiMain->execute()
#6 /srv/mediawiki/w/api.php(3): include(string)

JCApi.php:34 Trace

#0 /srv/mediawiki/php-1.32.0-wmf.20/extensions/JsonConfig/includes/JCApi.php(34): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.32.0-wmf.20/extensions/JsonConfig/includes/JCApi.php(64): JsonConfig\JCApi::addStatusConf(stdClass)
#2 /srv/mediawiki/php-1.32.0-wmf.20/includes/api/ApiMain.php(1587): JsonConfig\JCApi->execute()
#3 /srv/mediawiki/php-1.32.0-wmf.20/includes/api/ApiMain.php(531): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.32.0-wmf.20/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.32.0-wmf.20/api.php(87): ApiMain->execute()
#6 /srv/mediawiki/w/api.php(3): include(string)

Notes

Different wikis, mostly API.

Details

	Subject	Repo	Branch	Lines +/-
	Fix PHP production error and update documentation	mediawiki/extensions/JsonConfig	master	+54 -53

Customize query in gerrit

Related Objects

Mentioned In: T231556: JCApi.php: PHP Notice: Trying to get property [PROPERTY] of non-object
T158356: Cannot access property on non-object in JCTabularContent.php on line 40

Event Timeline

Krinkle created this task.Sep 17 2018, 6:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2018, 6:34 PM

Krinkle mentioned this in T158356: Cannot access property on non-object in JCTabularContent.php on line 40.Sep 17 2018, 7:47 PM

Krinkle updated the task description. (Show Details)Sep 21 2018, 6:42 PM

Krinkle updated the task description. (Show Details)

Krinkle moved this task from Apr 2019 / 1.33.wmf.25+ to Older on the Wikimedia-production-error board.Sep 26 2018, 2:37 AM

(Still seen on 1.32-wmf.24)

zeljkofilipin added a project: User-zeljkofilipin.Mar 21 2019, 2:40 PM

zeljkofilipin moved this task from Backlog 🪒 to Project ♟ on the User-zeljkofilipin board.

Tgr moved this task from Older to Apr 2019 / 1.33.wmf.25+ on the Wikimedia-production-error board.Mar 21 2019, 11:26 PM

Tgr moved this task from Apr 2019 / 1.33.wmf.25+ to Older on the Wikimedia-production-error board.

Analysis by @TheDJ.

Example query to trigger this is https://koi.wikipedia.org/w/api.php?action=jsonconfig&formatversion=2.

Example output from that query:

{   "models": { … },
    "titleMap": {
        "480": [ … ],
        "486": [
            {   "model": "Tabular.JsonConfig",
                "namespace": 486,
                "nsName": "Data",
                "nsTalk": "default",
                "isLocal": false,
                "cacheExp": 86400,
                "cacheKey": "",
                "flaggedRevs": false,
                "remote": {
                    "url": "https://commons.wikimedia.org/w/api.php",
                    "username": false,
                    "password": false
                },
                "store": {
                    "cacheNewValue": null,
                    "notifyUrl": null,
                    "notifyUsername": true,
                    "notifyPassword": true
                }
            },

The code in question is from extensions/JsonConfig/JCApi.php:

		if ( isset( $conf->store ) ) {
			$res['store'] = [
				'cacheNewValue' => $conf->store->cacheNewValue,
				'notifyUrl' => $conf->store->notifyUrl,
				'notifyUsername' => $conf->store->notifyUsername !== '', // true or false
				'notifyPassword' => $conf->store->notifyPassword !== '', // true or false
			];
		}

Virtually always when this API is called, $conf->store is set, but set to boolean false, not an object. As such, all four of these members are non-existent and implicitly null.

This means cacheNewValue and notifyUrl are output as null. And notifyUsername is unexpectedly set to true instead of false, because the code assumes empty string as the bottom value, which null is not.

Side note: This is still broadcasting https://zero.wikimedia.org/w/api.php, which should presumably be disabled at some point?

Krinkle merged a task: T224096: [JsonConfig] PHP Notice: Cannot access property on non-object.May 24 2019, 3:12 PM

Krinkle added a subscriber: hashar.

• Nforcer7 removed projects: User-zeljkofilipin, JsonConfig.Aug 1 2019, 5:12 PM

• Nforcer7 closed this task as Invalid.Aug 1 2019, 5:17 PM

• Nforcer7 removed a project: Wikimedia-production-error.

• Nforcer7 removed subscribers: TheDJ, Aklapper, Krinkle.

Aklapper added subscribers: TheDJ, Aklapper, Krinkle.Aug 1 2019, 5:48 PM

Aklapper reopened this task as Open.Aug 1 2019, 5:51 PM

Aklapper added projects: Wikimedia-production-error, User-zeljkofilipin, JsonConfig.

TheDJ added a project: User-TheDJ.Aug 1 2019, 7:08 PM

zeljkofilipin removed a project: User-zeljkofilipin.Aug 21 2019, 1:46 PM

Krinkle unsubscribed.Aug 21 2019, 2:32 PM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM

Krinkle mentioned this in T231556: JCApi.php: PHP Notice: Trying to get property [PROPERTY] of non-object.Sep 17 2019, 4:09 PM

JsonConfig is the most common producer of errors in the production logs over the past few weeks, this makes deployments more difficult and risky than they need to be. Tagging Product-Infra per mw:Maintainers page to hopefully look into this.

LGoto triaged this task as Medium priority.Oct 16 2019, 3:42 PM

LGoto moved this task from Needs triage to Needs investigation on the Product-Infrastructure-Team-Backlog-Deprecated board.

Change 545848 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/extensions/JsonConfig@master] Fix PHP production error and update documentation

https://gerrit.wikimedia.org/r/545848

gerritbot added a project: Patch-For-Review.Oct 24 2019, 1:41 PM

MSantos claimed this task.Oct 24 2019, 3:12 PM

MSantos moved this task from Needs investigation to Kanban on the Product-Infrastructure-Team-Backlog-Deprecated board.

MSantos edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.

MSantos moved this task from To Do to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Oct 24 2019, 3:17 PM

Change 545848 merged by jenkins-bot:
[mediawiki/extensions/JsonConfig@master] Fix PHP production error and update documentation

https://gerrit.wikimedia.org/r/545848

MSantos moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Oct 24 2019, 6:56 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.4; 2019-10-29).Oct 24 2019, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 24 2019, 7:10 PM

• Mholloway moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Nov 5 2019, 3:29 PM