Maniphest T204581

Add "done" message on emptied table (monuments_without_id)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lokal_Profil
	Sep 17 2018, 6:53 PM

Tags

Referenced Files

None

Subscribers

Description

Currently monuments_without_id.py outputs an empty gallery (only) to the report when no matching images are found.

It would be better to output a (l10n-able) message explaining there are no needed actions.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Handle empty report	labs/tools/heritage	master	+29 -9

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Lokal_Profil	T176724 Re-enable monuments_without_id reports
		Resolved		Lokal_Profil	T204581 Add "done" message on emptied table (monuments_without_id)
		Resolved		Lokal_Profil	T205789 create "Images without Id" explanation page

Event Timeline

Lokal_Profil created this task.Sep 17 2018, 6:53 PM

Change 461593 had a related patch set uploaded (by Lokal Profil; owner: Lokal Profil):
[labs/tools/heritage@master] Handle empty report

https://gerrit.wikimedia.org/r/461593

gerritbot added a project: Patch-For-Review.Sep 20 2018, 8:01 AM

Lokal_Profil claimed this task.Sep 20 2018, 1:42 PM

Lokal_Profil mentioned this in T204552: Handled malformated templates (monuments_without_id).Sep 30 2018, 3:46 PM

Change 461593 merged by jenkins-bot:
[labs/tools/heritage@master] Handle empty report

https://gerrit.wikimedia.org/r/461593

Lokal_Profil closed this task as Resolved.Oct 1 2018, 3:53 PM

Mentioned in SAL (#wikimedia-cloud) [2018-10-02T21:02:19Z] <Lokal_Profil> Deploy latest from Git master: 33ab2cc, 7e7533f, 07bf55b, 63530f4, ae38b67, 5747927 (T203349), 72822ee (T204581), 35e9b82 (T204580), 0b2466a (T176724)

Stashbot mentioned this in T204580: Limit size of gallery (monuments_without_id).Oct 2 2018, 9:02 PM

Stashbot mentioned this in T176724: Re-enable monuments_without_id reports.

Effeietsanders closed subtask T205789: create "Images without Id" explanation page as Resolved.Nov 18 2018, 1:55 AM