Page MenuHomePhabricator
Create Task
Maniphest T204616

Remove unexpected line-break from Special:Gadgets between "required rights" list and "on by default"
Closed, ResolvedPublic
Actions

Assigned To
Krinkle
Authored By
Krinkle
Sep 17 2018, 10:33 PM
Tags
Referenced Files
F26206451: Screen Shot 2018-09-26 at 03.44.46.png
Sep 26 2018, 2:47 AM
F26206447: Screen Shot 2018-09-26 at 03.44.43.png
Sep 26 2018, 2:47 AM
F26108817: Special Gadgets broken cropped.png
Sep 20 2018, 5:20 PM
F25996251: capture.png
Sep 17 2018, 10:33 PM
Subscribers
Aklapper
gerritbot
Krinkle
Nirmos

Description

capture.png (828×1 px, 205 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
SpecialGadgets: Restore line breaks between actions and usesmediawiki/extensions/Gadgetswmf/1.32.0-wmf.23+5 -0
SpecialGadgets: Restore line breaks between actions and usesmediawiki/extensions/Gadgetsmaster+5 -0
SpecialGadgets: Omit blank space due to <br> between <ul> and <p>mediawiki/extensions/Gadgetsmaster+42 -19
Customize query in gerrit

Event Timeline

Krinkle created this task.Sep 17 2018, 10:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2018, 10:33 PM
Krinkle claimed this task.Sep 17 2018, 10:33 PM
Krinkle triaged this task as Low priority.
gerritbot subscribed.Sep 17 2018, 10:34 PM

Change 460996 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/Gadgets@master] SpecialGadgets: Omit blank space due to <br> between <ul> and <p>

https://gerrit.wikimedia.org/r/460996

gerritbot added a project: Patch-For-Review.Sep 17 2018, 10:34 PM
Jdforrester-WMF closed this task as Resolved.Sep 17 2018, 11:27 PM
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Sep 17 2018, 11:43 PM

Change 460996 merged by jenkins-bot:
[mediawiki/extensions/Gadgets@master] SpecialGadgets: Omit blank space due to <br> between <ul> and <p>

https://gerrit.wikimedia.org/r/460996

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 18 2018, 12:00 AM
Nirmos reopened this task as Open.Sep 20 2018, 5:20 PM
Nirmos subscribed.

Now there is no line break between "(View source | Export)" and "Uses:"

Special Gadgets broken cropped.png (965×1 px, 228 KB)

• Imarlier moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Sep 24 2018, 8:20 PM
gerritbot added a comment.Sep 26 2018, 2:46 AM

Change 462840 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/Gadgets@master] SpecialGadgets: Restore line breaks between actions and uses

https://gerrit.wikimedia.org/r/462840

gerritbot added a project: Patch-For-Review.Sep 26 2018, 2:46 AM
Krinkle added a comment.Sep 26 2018, 2:47 AM
In T204616#4617781, @gerritbot wrote:

Change 462840 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/Gadgets@master] SpecialGadgets: Restore line breaks between actions and uses

https://gerrit.wikimedia.org/r/462840

BeforeAfter
Screen Shot 2018-09-26 at 03.44.43.png (888×1 px, 185 KB)
Screen Shot 2018-09-26 at 03.44.46.png (838×932 px, 141 KB)
Krinkle removed a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 26 2018, 2:47 AM
Krinkle moved this task from Doing (old) to Blocked (old) on the Performance-Team board.
gerritbot added a comment.Sep 26 2018, 6:07 PM

Change 463124 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/Gadgets@wmf/1.32.0-wmf.23] SpecialGadgets: Restore line breaks between actions and uses

https://gerrit.wikimedia.org/r/463124

gerritbot added a comment.Sep 26 2018, 6:12 PM

Change 462840 merged by jenkins-bot:
[mediawiki/extensions/Gadgets@master] SpecialGadgets: Restore line breaks between actions and uses

https://gerrit.wikimedia.org/r/462840

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)).Sep 26 2018, 7:00 PM
gerritbot added a comment.Sep 26 2018, 7:31 PM

Change 463124 merged by jenkins-bot:
[mediawiki/extensions/Gadgets@wmf/1.32.0-wmf.23] SpecialGadgets: Restore line breaks between actions and uses

https://gerrit.wikimedia.org/r/463124

Krinkle removed a project: Patch-For-Review.Sep 26 2018, 7:42 PM
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)); removed MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)).Sep 26 2018, 8:00 PM
Krinkle closed this task as Resolved.Sep 26 2018, 8:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits