Page MenuHomePhabricator

Use Promise.async / yield instead of Promises wherever feasible without hurting performance
Closed, ResolvedPublic

Description

Newer node versions support synchronous-like code syntax for async code patterns via the async / yield features. Using them has the benefit of making the JS code more readable as well as making it easier to port it to PHP.

Event Timeline

ssastry triaged this task as Medium priority.Sep 17 2018, 10:48 PM
ssastry moved this task from Backlog to Post-Port Work on the Parsoid-PHP board.
Dinoguy1000 renamed this task from Use async / yield instead of Promises wherever feasible without huring performance to Use async / yield instead of Promises wherever feasible without hurting performance.Sep 18 2018, 1:35 AM

Change 408882 had a related patch set uploaded (by Arlolra; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Convert LinkHandler to async/await.

https://gerrit.wikimedia.org/r/408882

cscott renamed this task from Use async / yield instead of Promises wherever feasible without hurting performance to Use Promise.async / yield instead of Promises wherever feasible without hurting performance.Oct 2 2018, 9:03 PM