Page MenuHomePhabricator

Get rid of JsonFileEntityLookup in WikibaseQualityConstraints tests
Open, LowPublic


Some of the WBQC tests use the JsonFileEntityLookup class to load test data from Q….json files in the test directory. This bloats the repository (the JSON files are usually verbose, and much longer than a NewItem version with the same important parts) and makes the tests unreadable (you have to peruse the Q5.json file to understand the properties of the Q5 entity referenced in test code). For new tests, we’ve instead been using the NewItem and NewStatement builders from some time, and some existing tests have been migrated to that as well; we should finish that migration and get rid of JsonFileEntityLookup completely.


Related Gerrit Patches:
mediawiki/extensions/WikibaseQualityConstraints : masterStop using JsonFileEntityLookup in ConnectionChecker tests

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 18 2018, 12:33 PM
Addshore moved this task from incoming to ready to go on the Wikidata board.Sep 19 2018, 7:17 AM
Addshore triaged this task as Low priority.Jun 20 2019, 11:24 PM
Addshore added a subscriber: Addshore.

Been on the campsite since the end of 2018 but not picked up any further.
This ticket is basically "Ready to go" so maybe we should but it there?
But also this is low impact in the grand schema of things, so perhaps we should hold off on that.
Also low cost, and could be a good candidate for a volunteer, or an on boarding task?

Change 521557 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Stop using JsonFileEntityLookup in ConnectionChecker tests

Change 521557 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Stop using JsonFileEntityLookup in ConnectionChecker tests