Page MenuHomePhabricator
Create Task
Maniphest T204704

Get rid of JsonFileEntityLookup in WikibaseQualityConstraints tests
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Some of the WBQC tests use the JsonFileEntityLookup class to load test data from Q….json files in the test directory. This bloats the repository (the JSON files are usually verbose, and much longer than a NewItem version with the same important parts) and makes the tests unreadable (you have to peruse the Q5.json file to understand the properties of the Q5 entity referenced in test code). For new tests, we’ve instead been using the NewItem and NewStatement builders from some time, and some existing tests have been migrated to that as well; we should finish that migration and get rid of JsonFileEntityLookup completely.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove JsonFileEntityLookupmediawiki/extensions/WikibaseQualityConstraintsmaster+0 -96
Remove redundant JSON files used for PHPunit testsmediawiki/extensions/WikibaseQualityConstraintsmaster+0 -939
Stop using JsonFileEntityLookup in TypeChecker testsmediawiki/extensions/WikibaseQualityConstraintsmaster+338 -49
Stop using JsonFileEntityLookup in ConnectionChecker testsmediawiki/extensions/WikibaseQualityConstraintsREL1_31+381 -559
Stop using JsonFileEntityLookup in ConnectionChecker testsmediawiki/extensions/WikibaseQualityConstraintsmaster+381 -559
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Sep 18 2018, 12:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 18 2018, 12:33 PM
Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite.Sep 18 2018, 12:34 PM
Lucas_Werkmeister_WMDE mentioned this in T168240: WBQC test improvements.
Addshore moved this task from incoming to ready to go on the Wikidata board.Sep 19 2018, 7:17 AM
Addshore moved this task from Inbox to CI & Testing on the [DEPRECATED] wdwb-tech board.Oct 8 2018, 12:53 PM
Addshore added a project: Technical-Debt.Oct 31 2018, 4:42 PM
Addshore triaged this task as Low priority.Jun 20 2019, 11:24 PM
Addshore edited projects, added patch-welcome, Wikidata-Trailblazing-Exploration; removed Wikidata-Campsite.
Addshore subscribed.

Been on the campsite since the end of 2018 but not picked up any further.
This ticket is basically "Ready to go" so maybe we should but it there?
But also this is low impact in the grand schema of things, so perhaps we should hold off on that.
Also low cost, and could be a good candidate for a volunteer, or an on boarding task?

Addshore moved this task from Backlog to Ignored on the Wikidata-Trailblazing-Exploration board.Jun 20 2019, 11:25 PM
gerritbot added a comment.Jul 9 2019, 6:07 PM

Change 521557 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Stop using JsonFileEntityLookup in ConnectionChecker tests

https://gerrit.wikimedia.org/r/521557

gerritbot added a project: Patch-For-Review.Jul 9 2019, 6:07 PM
gerritbot added a comment.Jul 11 2019, 12:15 AM

Change 521557 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Stop using JsonFileEntityLookup in ConnectionChecker tests

https://gerrit.wikimedia.org/r/521557

Lucas_Werkmeister_WMDE mentioned this in rEBQC9fa2f7ef8521: Stop using JsonFileEntityLookup in ConnectionChecker tests.Jul 11 2019, 12:17 AM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Jul 11 2019, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 11 2019, 1:10 AM
gerritbot added a comment.Jul 24 2020, 1:50 AM

Change 615858 had a related patch set uploaded (by Reedy; owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@REL1_31] Stop using JsonFileEntityLookup in ConnectionChecker tests

https://gerrit.wikimedia.org/r/615858

gerritbot added a project: Patch-For-Review.Jul 24 2020, 1:50 AM
gerritbot added a comment.Jul 24 2020, 2:11 AM

Change 615858 merged by Reedy:
[mediawiki/extensions/WikibaseQualityConstraints@REL1_31] Stop using JsonFileEntityLookup in ConnectionChecker tests

https://gerrit.wikimedia.org/r/615858

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2020, 3:10 AM
Addshore moved this task from CI & Testing to Small Code Fixes on the [DEPRECATED] wdwb-tech board.Jan 22 2021, 9:32 PM

@Lucas_Werkmeister_WMDE Any idea if this is done / if there is more to do?

Addshore moved this task from Small Code Fixes to legacy-backlog on the [DEPRECATED] wdwb-tech board.Jan 22 2021, 10:39 PM
Addshore edited projects, added [DEPRECATED] wdwb-tech (legacy-backlog); removed [DEPRECATED] wdwb-tech.
Lucas_Werkmeister_WMDE added a comment.Jan 25 2021, 10:33 AM
$ find tests/ -name '*.json' | wc -l
16
$ git grep JsonFileEntityLookup tests/ | wc -l
14

Not done yet.

Addshore edited projects, added [DEPRECATED] wdwb-tech; removed [DEPRECATED] wdwb-tech (legacy-backlog).Mar 18 2021, 12:31 PM
Addshore moved this task from Inbox to Triaged Low (0-50) on the [DEPRECATED] wdwb-tech board.
Addshore added a project: Wikidata-Campsite.Apr 15 2021, 9:22 AM
Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.
Lucas_Werkmeister_WMDE mentioned this in T282851: Remove MockEditDiskRequest.May 14 2021, 8:46 AM
Addshore removed a project: Wikidata-Campsite.Jul 20 2021, 2:52 PM
ItamarWMDE added a project: wmde-wikidata-tech.Aug 17 2022, 10:35 AM
Maintenance_bot moved this task from Triaged Low (0-50) to Sorted Team A on the [DEPRECATED] wdwb-tech board.Aug 17 2022, 11:15 AM
ItamarWMDE subscribed.Sep 27 2022, 1:22 PM

Prio Notes:

  • Does not affect end users / production
  • Affects development efforts
  • Does not affect onboarding efforts
  • Does not affect additional stakeholders
ItamarWMDE moved this task from Incoming to [DOT] Prioritized on the wmde-wikidata-tech board.Sep 27 2022, 1:33 PM
ItamarWMDE added a project: [Archived]Wikidata Dev Team.
ItamarWMDE moved this task from Incoming to [DOT] Tech Backlog on the [Archived]Wikidata Dev Team board.Sep 27 2022, 2:06 PM
karapayneWMDE set the point value for this task to 3.Dec 20 2022, 2:34 PM
karapayneWMDE moved this task from [DOT] Tech Backlog to SEND TO OMEGA BOARD. Will land in the 'incoming' column and need to be moved to the correct location (former Unified DOT Backlog) on the [Archived]Wikidata Dev Team board.
• noarave claimed this task.Jan 3 2023, 9:27 AM
Restricted Application added a project: User-Noarave. · View Herald TranscriptJan 3 2023, 9:27 AM
• noarave moved this task from SEND TO OMEGA BOARD. Will land in the 'incoming' column and need to be moved to the correct location (former Unified DOT Backlog) to Sprint-∞ on the [Archived]Wikidata Dev Team board.Jan 3 2023, 9:28 AM
• noarave edited projects, added [Archived]Wikidata Dev Team (Sprint-∞); removed [Archived]Wikidata Dev Team.
• noarave moved this task from Parents/Waiting to Doing on the [Archived]Wikidata Dev Team (Sprint-∞) board.
gerritbot added a comment.Jan 6 2023, 1:41 PM

Change 876195 had a related patch set uploaded (by Noa wmde; author: Noa wmde):

[mediawiki/extensions/WikibaseQualityConstraints@master] Stop using JsonFileEntityLookup in CheckerHelper tests

https://gerrit.wikimedia.org/r/876195

gerritbot added a project: Patch-For-Review.Jan 6 2023, 1:41 PM
• noarave moved this task from Doing to Peer Review on the [Archived]Wikidata Dev Team (Sprint-∞) board.Jan 11 2023, 10:29 AM
gerritbot added a comment.Jan 18 2023, 3:44 PM

Change 876195 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Stop using JsonFileEntityLookup in TypeChecker tests

https://gerrit.wikimedia.org/r/876195

Lucas_Werkmeister_WMDE moved this task from Peer Review to Todo/Backlog on the [Archived]Wikidata Dev Team (Sprint-∞) board.Jan 18 2023, 3:47 PM

I think that was the last use of JsonFileEntityLookup \o/

Left to do:

  • Remove the class itself, as well as its mention in the README
  • Remove the unused JSON files
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 18 2023, 4:00 PM
ItamarWMDE moved this task from [DOT] Prioritized to Ongoing on the wmde-wikidata-tech board.Jan 18 2023, 4:07 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 18 2023, 4:31 PM
gerritbot added a comment.Jan 19 2023, 12:08 PM

Change 881575 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Remove JsonFileEntityLookup

https://gerrit.wikimedia.org/r/881575

gerritbot added a project: Patch-For-Review.Jan 19 2023, 12:08 PM
Lucas_Werkmeister_WMDE moved this task from Todo/Backlog to Peer Review on the [Archived]Wikidata Dev Team (Sprint-∞) board.Jan 19 2023, 12:09 PM
gerritbot added a comment.Jan 19 2023, 12:18 PM

Change 881582 had a related patch set uploaded (by Noa wmde; author: Noa wmde):

[mediawiki/extensions/WikibaseQualityConstraints@master] Remove redundant JSON files used for PHPunit tests

https://gerrit.wikimedia.org/r/881582

gerritbot added a comment.Jan 19 2023, 12:35 PM

Change 881582 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Remove redundant JSON files used for PHPunit tests

https://gerrit.wikimedia.org/r/881582

gerritbot added a comment.Jan 19 2023, 12:37 PM

Change 881575 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Remove JsonFileEntityLookup

https://gerrit.wikimedia.org/r/881575

Lucas_Werkmeister_WMDE closed this task as Resolved.Jan 19 2023, 1:30 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Our work done on the [Archived]Wikidata Dev Team (Sprint-∞) board.
karapayneWMDE moved this task from Our work done to 2023 completed tasks on the [Archived]Wikidata Dev Team (Sprint-∞) board.Feb 6 2023, 4:07 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 6 2023, 4:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits