Maniphest T204710

make-wmf-branch: no permission on lib/ve VisualEditor submodule
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Sep 18 2018, 1:50 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

gerritbot

hashar

Description

I have cut the branch and it failed, I then tried again but since the VisualEditor submodule got fetched out I got:

Cloning into '/tmp/make-wmf-branch/VisualEditor/lib/ve'...
Submodule path 'lib/ve': checked out '7420443fe551e44ae4180c8b14b542d7e8ed9de1'
cd lib/ve
'git' 'checkout' '-q' '-b' 'wmf/1.32.0-wmf.22'
'git' 'push' 'origin' 'wmf/1.32.0-wmf.22'
Permission denied (publickey).
fatal: Could not read from remote repository.

The script should not attempt to make a branch for an extension submodule.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	admin: hashar: drop git pushInsteadOf	Hashar	operations/puppet	production	+0 -2

Customize query in gerrit

Event Timeline

hashar created this task.Sep 18 2018, 1:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 18 2018, 1:50 PM

All remotes use https but for lib/ve I have ssh as a push url:

hashar@deploy1001:/tmp/make-wmf-branch/VisualEditor/lib/ve$ git remote -v
origin	https://gerrit.wikimedia.org/r/p/VisualEditor/VisualEditor.git (fetch)
origin	ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor.git (push)

Because my ~/.gitconfig has:

[url "ssh://gerrit.wikimedia.org:29418"]
	pushInsteadOf = https://gerrit.wikimedia.org/r/p

Change 461134 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] admin: hashar: drop git pushInsteadOf

https://gerrit.wikimedia.org/r/461134

gerritbot added a project: Patch-For-Review.Sep 18 2018, 2:07 PM

hashar claimed this task.Sep 18 2018, 2:07 PM

Change 461134 merged by Ema:
[operations/puppet@production] admin: hashar: drop git pushInsteadOf

https://gerrit.wikimedia.org/r/461134

hashar closed this task as Resolved.Sep 18 2018, 2:24 PM

make-wmf-branch: no permission on lib/ve VisualEditor submoduleClosed, ResolvedPublicActions

Description

Details

Event Timeline

make-wmf-branch: no permission on lib/ve VisualEditor submodule
Closed, ResolvedPublic
Actions