Maniphest T204758

EchoForeignWikiRequest emits PHP error "Undefined index: csrftoken"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Krinkle
	Sep 18 2018, 7:50 PM

Description

Error

Request ID: W6FWgQrAAFEAAH2KCscAAABP

message

PHP Notice: Undefined index: csrftoken

stacktrace

#1 /srv/mediawiki/php-1.32.0-wmf.22/extensions/Echo/includes/ForeignWikiRequest.php(153): EchoForeignWikiRequest->getCsrfToken(string)
#2 /srv/mediawiki/php-1.32.0-wmf.22/extensions/Echo/includes/ForeignWikiRequest.php(134): EchoForeignWikiRequest->getQueryParams(string)
#3 /srv/mediawiki/php-1.32.0-wmf.22/extensions/Echo/includes/ForeignWikiRequest.php(36): EchoForeignWikiRequest->getRequestParams(string, array)
#4 /srv/mediawiki/php-1.32.0-wmf.22/extensions/Echo/includes/api/ApiCrossWiki.php(38): EchoForeignWikiRequest->execute()
#5 /srv/mediawiki/php-1.32.0-wmf.22/extensions/Echo/includes/api/ApiEchoNotifications.php(44): ApiEchoNotifications->getFromForeign()
#6 /srv/mediawiki/php-1.32.0-wmf.22/includes/api/ApiQuery.php(249): ApiEchoNotifications->execute()
#7 /srv/mediawiki/php-1.32.0-wmf.22/includes/api/ApiMain.php(1587): ApiQuery->execute()
#8 /srv/mediawiki/php-1.32.0-wmf.22/includes/api/ApiMain.php(531): ApiMain->executeAction()
#9 /srv/mediawiki/php-1.32.0-wmf.22/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#10 /srv/mediawiki/php-1.32.0-wmf.22/api.php(87): ApiMain->execute()

Notes

Seen in API queries from mediawiki.org.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	ApiCrossWiki: Handle needsToken() returning false	mediawiki/extensions/Echo	wmf/1.32.0-wmf.22	+2 -1
	ApiCrossWiki: Handle needsToken() returning false	mediawiki/extensions/Echo	master	+2 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	hashar	T191068 1.32.0-wmf.22 deployment blockers
		Resolved	PRODUCTION ERROR	Catrope	T204758 EchoForeignWikiRequest emits PHP error "Undefined index: csrftoken"

Event Timeline

Krinkle created this task.Sep 18 2018, 7:50 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 18 2018, 7:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Krinkle moved this task from Untriaged to Nov2019/1.35.wmf.5+ on the Wikimedia-production-error board.Sep 18 2018, 7:50 PM

Krinkle added a parent task: T191068: 1.32.0-wmf.22 deployment blockers.

SBisson subscribed.Sep 18 2018, 8:47 PM

Change 461217 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/Echo@master] Specify the type of token when needed

https://gerrit.wikimedia.org/r/461217

gerritbot added a project: Patch-For-Review.Sep 18 2018, 9:13 PM

SBisson assigned this task to Catrope.Sep 19 2018, 10:39 AM

SBisson edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

SBisson moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 461217 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] ApiCrossWiki: Handle needsToken() returning false

https://gerrit.wikimedia.org/r/461217

Change 461363 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/Echo@wmf/1.32.0-wmf.22] ApiCrossWiki: Handle needsToken() returning false

https://gerrit.wikimedia.org/r/461363

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Sep 19 2018, 11:00 AM

Krinkle mentioned this in T204826: EchoForeignWikiRequest emits PHP error "Undefined index: query".Sep 19 2018, 2:27 PM

(Train blocker == UBN!)

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptSep 19 2018, 2:36 PM

Change 461363 merged by jenkins-bot:
[mediawiki/extensions/Echo@wmf/1.32.0-wmf.22] ApiCrossWiki: Handle needsToken() returning false

https://gerrit.wikimedia.org/r/461363

Mentioned in SAL (#wikimedia-operations) [2018-09-19T16:49:58Z] <sbisson@deploy1001> Synchronized php-1.32.0-wmf.22/extensions/Echo/includes/api/ApiCrossWiki.php: T204758 (duration: 00m 57s)