Maniphest T204786

mobile.startup
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

View.js has already been migrated to webpack's control via T203100, but its associated tests proved to be challenging to migrate due to tight coupling with dependencies ( e.g. jQuery) and a lot of stubbing in its place. It was thus decided to leave its test file as is and migrate it in a future card (this one).

To review the work already done on this, see (and feel free to abandon): https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/458883/

A discussion needs to be had on how much stubbing / spying we feel comfortable with on this.

Acceptance criteria

test_View.js is migrated to tests/node-qunit/mobile.startup and can be run from headless qunit
Revise/move/remove any tests that don't test View's responsibility. Note: some tests feel like they test the functionality of mfExtend more than they test View's code

Note: Adding additional test coverage is out of scope and will be added separately.

Sign off steps

Measure and record code coverage on the wiki page

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove redundant View tests	mediawiki/extensions/MobileFrontend	master	+0 -144
	Hygiene: enable headless View tests	mediawiki/extensions/MobileFrontend	master	+333 -343

Customize query in gerrit

Related Objects

Mentioned In: T206226: Migrate PageGateway.test.js to tests/node-qunit/mobile.startup
T203100: Continue webpack + test transition of mobile.startup
Mentioned Here: T203100: Continue webpack + test transition of mobile.startup

Event Timeline

• nray created this task.Sep 18 2018, 11:40 PM

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptSep 18 2018, 11:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• nray added a project: MobileFrontend (MobileFrontend and MinervaNeue architecture).Sep 18 2018, 11:41 PM

• nray updated the task description. (Show Details)

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog-Archived board.Sep 18 2018, 11:46 PM

Jdlrobson moved this task from Backlog to Code coverage on the MobileFrontend (MobileFrontend and MinervaNeue architecture) board.Sep 18 2018, 11:53 PM

Jdlrobson triaged this task as Medium priority.Sep 19 2018, 4:24 PM

• nray mentioned this in T203100: Continue webpack + test transition of mobile.startup.Sep 19 2018, 5:45 PM

• Niedzielski subscribed.Sep 24 2018, 8:28 PM

I subject we'll be able to port this soon.

ovasileva set the point value for this task to 2.Sep 26 2018, 4:11 PM

Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog-Archived board.Sep 26 2018, 11:13 PM

Change 463845 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Hygiene: enable headless View tests

https://gerrit.wikimedia.org/r/463845

gerritbot added a project: Patch-For-Review.Oct 1 2018, 8:40 PM

Jdrewniak edited projects, added Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Web-Team-Backlog-Archived.Oct 3 2018, 8:33 PM

Jdrewniak removed a project: Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2).Oct 3 2018, 8:46 PM

There's a patch for review.

Jdlrobson moved this task from To Do to Needs Code Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 3 2018, 8:56 PM

Jdlrobson moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 3 2018, 9:16 PM

Jdlrobson mentioned this in T206226: Migrate PageGateway.test.js to tests/node-qunit/mobile.startup.Oct 4 2018, 2:50 PM

• Niedzielski moved this task from Needs More Work to To Do on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 4 2018, 5:18 PM

• Niedzielski updated the task description. (Show Details)

Change 464726 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Remove redundant View tests

https://gerrit.wikimedia.org/r/464726

Jdlrobson moved this task from To Do to Needs Code Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 4 2018, 9:54 PM

Change 463845 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: enable headless View tests

https://gerrit.wikimedia.org/r/463845

• nray moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 4 2018, 10:53 PM

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 4 2018, 11:01 PM

Jdlrobson moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 5 2018, 3:07 PM

Jdlrobson updated the task description. (Show Details)Oct 5 2018, 6:10 PM

Jdlrobson assigned this task to • nray.Oct 8 2018, 5:17 PM