Page MenuHomePhabricator
Create Task
Maniphest T204800

Unable to view Special:DoubleRedirects on tt.wikipedia.org due to PHP Fatal from Title.php
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request ID: W3reBwpAAEUAAICDY38AAABV

message
[{exception_id}] {exception_url}   BadMethodCallException from line 1610 of /srv/mediawiki/php-1.32.0-wmf.20/includes/Title.php: Call to a member function isLocal() on a non-object (null)
stacktrace
#0 /srv/mediawiki/php-1.32.0-wmf.20/includes/Title.php(1923): Title->getFragmentForURL()
#1 /srv/mediawiki/php-1.32.0-wmf.20/includes/Title.php(2081): Title->getFullURL(string, boolean, boolean)
#2 /srv/mediawiki/php-1.32.0-wmf.20/includes/linker/LinkRenderer.php(409): Title->getLinkURL(array, boolean, boolean)
#3 /srv/mediawiki/php-1.32.0-wmf.20/includes/linker/LinkRenderer.php(256): MediaWiki\Linker\LinkRenderer->getLinkURL(Title, array)
#4 /srv/mediawiki/php-1.32.0-wmf.20/includes/linker/LinkRenderer.php(299): MediaWiki\Linker\LinkRenderer->makePreloadedLink(Title, string, string, array, array)
#5 /srv/mediawiki/php-1.32.0-wmf.20/includes/specials/SpecialDoubleRedirects.php(193): MediaWiki\Linker\LinkRenderer->makeKnownLink(Title, string)
#6 /srv/mediawiki/php-1.32.0-wmf.20/includes/specialpage/QueryPage.php(704): DoubleRedirectsPage->formatResult(SkinVector, stdClass)
#7 /srv/mediawiki/php-1.32.0-wmf.20/includes/specialpage/QueryPage.php(672): QueryPage->outputResults(OutputPage, SkinVector, Wikimedia\Rdbms\DatabaseMysqli, Wikimedia\Rdbms\ResultWrapper, integer, integer)
#8 /srv/mediawiki/php-1.32.0-wmf.20/includes/specialpage/SpecialPage.php(569): QueryPage->execute(NULL)
#9 /srv/mediawiki/php-1.32.0-wmf.20/includes/specialpage/SpecialPageFactory.php(581): SpecialPage->run(NULL)
#10 /srv/mediawiki/php-1.32.0-wmf.20/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#11 /srv/mediawiki/php-1.32.0-wmf.20/includes/MediaWiki.php(868): MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.32.0-wmf.20/includes/MediaWiki.php(525): MediaWiki->main()
#13 /srv/mediawiki/php-1.32.0-wmf.20/index.php(42): MediaWiki->run()
#14 /srv/mediawiki/w/index.php(3): include(string)

Notes

A similar problem in the same class was previously reported and fixed in 2013 (T44649).

The problem can be consistently reproduced by simply viewing https://tt.wikipedia.org/wiki/Special:DoubleRedirects. Logstash first recorded it (this time) on 20 August (1.32.0-wmf.16).

Details

SubjectRepoBranchLines +/-
Fix Title::getFragmentForURL for bad interwiki prefix.mediawiki/coreREL1_32+122 -4
Fix Title::getFragmentForURL for bad interwiki prefix.mediawiki/corewmf/1.33.0-wmf.14+116 -4
Fix Title::getFragmentForURL for bad interwiki prefix.mediawiki/coremaster+116 -4
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Sep 19 2018, 3:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2018, 3:34 AM
Krinkle moved this task from Untriaged to Older on the Wikimedia-production-error board.Sep 19 2018, 3:34 AM
Krinkle added a comment.EditedOct 2 2018, 8:22 PM

Still seen on 1.32.0-wmf.23.

Raising priority of this one in particular because it exposes a fatal error on a public GET url, which is a risk for false alarms.

Krinkle renamed this task from PHP Fatal: Call to isLocal() on a non-object in Title.php (when viewing Special:DoubleRedirects on ttwiki) to Unable to view ttwiki/Special:DoubleRedirects due to PHP Fatal:"Call to isLocal() on a non-object in Title.php".Oct 2 2018, 8:22 PM
Krinkle triaged this task as High priority.
Krinkle mentioned this in Blog Post: Production Excellence #5: November 2018.Dec 12 2018, 4:40 AM
Krinkle renamed this task from Unable to view ttwiki/Special:DoubleRedirects due to PHP Fatal:"Call to isLocal() on a non-object in Title.php" to Unable to view Special:DoubleRedirects on tt.wikipedia.org due to PHP Fatal from Title.php.Jan 18 2019, 3:11 AM
Krinkle added a project: Platform Engineering.
Krinkle mentioned this in Blog Post: Production Excellence #6: December 2018.Jan 22 2019, 2:12 AM
CCicalese_WMF assigned this task to daniel.Jan 22 2019, 3:12 PM
CCicalese_WMF edited projects, added Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), Platform Team Workboards (Doing); removed Platform Engineering.
daniel added a comment.Jan 22 2019, 3:13 PM

Analysis: This code in getFragmentForURL() is missing a null check:

self::getInterwikiLookup()->fetch( $this->mInterwiki )->isLocal()
gerritbot added a subscriber: gerritbot.Jan 23 2019, 10:19 AM

Change 486045 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Fix Title::getFragmentForURL for bad interwiki prefix.

https://gerrit.wikimedia.org/r/486045

gerritbot added a project: Patch-For-Review.Jan 23 2019, 10:19 AM
daniel moved this task from Doing to Waiting for Review on the Platform Team Workboards board.Jan 23 2019, 10:21 AM
daniel edited projects, added Platform Team Workboards (Waiting for Review); removed Platform Team Workboards (Doing).
gerritbot added a comment.Jan 23 2019, 8:02 PM

Change 486045 merged by jenkins-bot:
[mediawiki/core@master] Fix Title::getFragmentForURL for bad interwiki prefix.

https://gerrit.wikimedia.org/r/486045

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Jan 23 2019, 9:00 PM
daniel added a comment.Jan 23 2019, 10:35 PM

Can be closed as soon as this has gone live and we have confirmed that the problem is fixed.

Does anyone think this needs a backport to 1.32? Or SWAT?

MarkAHershberger mentioned this in T214635: Title::getFragmentForURL can throw an error.Jan 24 2019, 8:40 PM
MarkAHershberger merged a task: T214635: Title::getFragmentForURL can throw an error.
MarkAHershberger added subscribers: MarkAHershberger, Hexmode.
Ciencia_Al_Poder added a subscriber: Ciencia_Al_Poder.Jan 25 2019, 10:36 AM
gerritbot added a comment.Feb 5 2019, 12:20 AM

Change 487976 had a related patch set uploaded (by Krinkle; owner: Daniel Kinzler):
[mediawiki/core@wmf/1.33.0-wmf.14] Fix Title::getFragmentForURL for bad interwiki prefix.

https://gerrit.wikimedia.org/r/487976

gerritbot added a comment.Feb 9 2019, 11:01 PM

Change 487976 abandoned by Krinkle:
Fix Title::getFragmentForURL for bad interwiki prefix.

Reason:
redundant.

https://gerrit.wikimedia.org/r/487976

gerritbot added a comment.Feb 9 2019, 11:07 PM

Change 489423 had a related patch set uploaded (by Krinkle; owner: Daniel Kinzler):
[mediawiki/core@REL1_32] Fix Title::getFragmentForURL for bad interwiki prefix.

https://gerrit.wikimedia.org/r/489423

Krinkle closed this task as Resolved.Feb 9 2019, 11:07 PM
gerritbot added a comment.Feb 9 2019, 11:49 PM

Change 489423 merged by jenkins-bot:
[mediawiki/core@REL1_32] Fix Title::getFragmentForURL for bad interwiki prefix.

https://gerrit.wikimedia.org/r/489423

ReleaseTaggerBot added a project: MW-1.32-notes.Feb 10 2019, 12:01 AM
CCicalese_WMF moved this task from Waiting for Review to Done with CPT on the Platform Team Workboards board.Feb 12 2019, 4:25 PM
CCicalese_WMF edited projects, added Platform Team Workboards (Done with CPT); removed Platform Team Workboards (Waiting for Review).
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 28 2019, 11:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL