Page MenuHomePhabricator

Exec error "Possibly missing executable file: svn diff" from Special:Code
Open, LowPublic

Description

Error

Request ID: W6HD6ArAAEMAAJiS9jIAAABU

level WARNING
Possibly missing executable file: /bin/bash '/srv/mediawiki/php-1.32.0-wmf.22/includes/shell/limit.sh' 'svn diff -r89146:89147 --non-interactive --trust-server-cert '\''http://svn.wikimedia.org/svnroot/mediawiki'\''' 'MW_INCLUDE_STDERR=;MW_CPU_LIMIT=50; MW_CGROUP='\''/sys/fs/cgroup/memory/mediawiki/job'\''; MW_MEM_LIMIT=1048576; MW_FILE_SIZE_LIMIT=524288; MW_WALL_CLOCK_LIMIT=180; MW_USE_LOG_PIPE=yes'
level ERROR
Error running /bin/bash '/srv/mediawiki/php-1.32.0-wmf.22/includes/shell/limit.sh' 'svn diff -r89146:89147 --non-interactive --trust-server-cert '\''http://svn.wikimedia.org/svnroot/mediawiki'\''' 'MW_INCLUDE_STDERR=;MW_CPU_LIMIT=50; MW_CGROUP='\''/sys/fs/cgroup/memory/mediawiki/job'\''; MW_MEM_LIMIT=1048576; MW_FILE_SIZE_LIMIT=524288; MW_WALL_CLOCK_LIMIT=180; MW_USE_LOG_PIPE=yes': 

/bin/bash: svn: command not found

Notes

Recorded in WMF Logstash since at least 19 August (the 30 day cut-off from today). Reproducible via https://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki/89147&action=purge.

Details

Related Gerrit Patches:
operations/puppet : productionInstall subversion on application servers

Event Timeline

Krinkle created this task.Sep 19 2018, 3:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2018, 3:42 AM

Looks like the latest server re-provisioning (Debian Stretch?) lost svn. Most diffs are still cached so breakage obvious at first given it only affects cache misses.

Either needs to be re-installed, or the CodeReview extension be amended to catch/ignore this error, or amended to implement it without svn command.

Change 462673 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Install subversion on application servers

https://gerrit.wikimedia.org/r/462673

Reedy added a subscriber: Reedy.Sep 25 2018, 6:51 PM

Isn't the problem here that the code review proxy (and/or it's config) is gone

AFAIK we never had svn installed on every server, because they didn't all hold a clone of the svn repo

See T116948: this extension is long gone. It had a wonderful life, and now it rests in peace; let's not devote resources to putting it back. There was a proposal to get an HTML dump of the contents and put them somewhere (T116948). @Legoktm ?

Krinkle added a comment.EditedSep 25 2018, 7:41 PM

@Reedy Indeed, they didn't have a full clone for CodeReview purposes, but from what I can tell, it's getting the diff from the svn server, not from locally. It's using the svn-diff command with a url, not a directory.

@ArielGlenn Agreed, but we probably need the diffs to work before we can make those dumps. I end up on a random SVN commit quite regularly and I'm fairly sure these diffs worked until recently. And they still work for a lot of commits due to caching.

@Krinkle Of course. But let's not reinstall svn everywhere just to get diffs working on one box, that's all I'm saying.

Krinkle added a comment.EditedSep 25 2018, 7:48 PM

Agreed. If that's easier, fine by me. Let's continue that conversation at T205361.

Change 462673 abandoned by Muehlenhoff:
Install subversion on application servers

https://gerrit.wikimedia.org/r/462673

Agreed. If that's easier, fine by me. Let's continue that conversation at T205361.

So "Declined" for this task and pick up further work at T205361?

MoritzMuehlenhoff triaged this task as Medium priority.Sep 28 2018, 9:19 AM
Krinkle lowered the priority of this task from Medium to Low.Oct 10 2018, 8:32 PM
Krinkle removed a project: Patch-For-Review.
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM