Page MenuHomePhabricator

wikitable download format TypeError if one of the columns is int
Closed, ResolvedPublic

Description

https://quarry.wmflabs.org/query/18904:

Sep 19 06:09:27 quarry-web-01 uwsgi-quarry-web[11639]: Traceback (most recent call last):
Sep 19 06:09:27 quarry-web-01 uwsgi-quarry-web[11639]:   File "/srv/quarry/venv/lib/python3.5/site-packages/werkzeug/wsgi.py", line 870, in __next__
Sep 19 06:09:27 quarry-web-01 uwsgi-quarry-web[11639]:     return self._next()
Sep 19 06:09:27 quarry-web-01 uwsgi-quarry-web[11639]:   File "/srv/quarry/venv/lib/python3.5/site-packages/werkzeug/wrappers.py", line 82, in _iter_encoded
Sep 19 06:09:27 quarry-web-01 uwsgi-quarry-web[11639]:     for item in iterable:
Sep 19 06:09:27 quarry-web-01 uwsgi-quarry-web[11639]:   File "./quarry/web/output.py", line 43, in _join_lines
Sep 19 06:09:27 quarry-web-01 uwsgi-quarry-web[11639]:     for v in gen:
Sep 19 06:09:27 quarry-web-01 uwsgi-quarry-web[11639]:   File "./quarry/web/output.py", line 122, in respond
Sep 19 06:09:27 quarry-web-01 uwsgi-quarry-web[11639]:     yield '|' + '||'.join(row)
Sep 19 06:09:27 quarry-web-01 uwsgi-quarry-web[11639]: TypeError: sequence item 0: expected str instance, int found

I guess my oversight on https://gerrit.wikimedia.org/r/#/c/analytics/quarry/web/+/460443/7/quarry/web/output.py

Event Timeline

Change 461281 had a related patch set uploaded (by Zhuyifei1999; owner: Zhuyifei1999):
[analytics/quarry/web@master] output.py: map(str, ...) for wikitable_formatter

https://gerrit.wikimedia.org/r/461281

Change 461281 merged by jenkins-bot:
[analytics/quarry/web@master] output.py: map(str, ...) for wikitable_formatter

https://gerrit.wikimedia.org/r/461281

Mentioned in SAL (#wikimedia-cloud) [2018-09-19T16:57:28Z] <framawiki> deployed 4994570 to quarry-web-01 T204805

Framawiki assigned this task to zhuyifei1999.