Page MenuHomePhabricator
Create Task
Maniphest T204816

LESS in ResourceLoader can't parse two ampersands on one line
Closed, ResolvedPublic
Actions

Description

.foo {
  &:not( &-bar ) {
    ...
  }
}

should parse to

.foo:not( .foo-bar ) { ...

but in ResourceLoader it parses to

.foo:not( &-bar ) { ...

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Less_Ruleset: Fix support for nested parent selectorsmediawiki/libs/less.phpmaster+355 -164
ResourceLoader: Update wikimedia/less.php to v3.2.1mediawiki/coremaster+2 -2
Misc clean up around Less_Ruleset for readability and less.js paritymediawiki/libs/less.phpmaster+100 -22
Avoid ResourceLoader LESS parsing bugmediawiki/coremaster+2 -1
Customize query in gerrit

Event Timeline

Esanders created this task.Sep 19 2018, 11:16 AM
Restricted Application added a project: Performance-Team. · View Herald TranscriptSep 19 2018, 11:16 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Sep 19 2018, 11:18 AM

Change 461369 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Avoid ResourceLoader LESS parsing bug

https://gerrit.wikimedia.org/r/461369

gerritbot added a project: Patch-For-Review.Sep 19 2018, 11:18 AM
Esanders added a comment.Sep 19 2018, 11:19 AM

The above patch works around the issue, it is not a fix.

Esanders added a comment.Sep 19 2018, 11:28 AM

less.php hasn't been touched in two years and has 88 open issues: https://github.com/oyejorge/less.php :/

gerritbot added a comment.Sep 19 2018, 3:34 PM

Change 461369 merged by jenkins-bot:
[mediawiki/core@master] Avoid ResourceLoader LESS parsing bug

https://gerrit.wikimedia.org/r/461369

Jdforrester-WMF removed a project: Patch-For-Review.Sep 19 2018, 3:41 PM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Sep 19 2018, 4:00 PM
• Imarlier moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Sep 24 2018, 8:17 PM
Alexia subscribed.Nov 30 2018, 9:17 PM
In T204816#4597618, @Esanders wrote:

less.php hasn't been touched in two years and has 88 open issues: https://github.com/oyejorge/less.php :/

It is not compatible with PHP 7.1+ either. There are many broken issues with the Less.php implementation.

Krinkle triaged this task as Low priority.Dec 10 2018, 2:49 AM
Krinkle removed a project: MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).
Krinkle moved this task from Inbox to Confirmed Problem on the MediaWiki-ResourceLoader board.
Krinkle changed the task status from Open to Stalled.Jun 6 2019, 10:20 AM
Krinkle edited projects, added Performance-Team (Radar), Upstream; removed Performance-Team.
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.
Krinkle edited projects, added Less.php; removed MediaWiki-ResourceLoader.Jan 17 2023, 11:32 AM
Krinkle edited projects, added MediaWiki-ResourceLoader; removed Upstream.
Esanders added a comment.Jan 17 2023, 5:35 PM

Now tracked upstream in https://github.com/wikimedia/less.php/issues/56

Krinkle changed the task status from Stalled to Open.Jan 19 2023, 1:59 AM
Krinkle claimed this task.
Krinkle edited projects, added Performance-Team; removed Performance-Team (Radar).
Krinkle updated the task description. (Show Details)
gerritbot added a comment.Jan 21 2023, 8:09 PM

Change 882187 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/libs/less.php@master] Misc clean up around Less_Ruleset for readability and less.js parity

https://gerrit.wikimedia.org/r/882187

gerritbot added a project: Patch-For-Review.Jan 21 2023, 8:09 PM
gerritbot added a comment.Jan 21 2023, 8:55 PM

Change 882188 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/libs/less.php@master] Less_Ruleset: Support nested parent selectors

https://gerrit.wikimedia.org/r/882188

gerritbot added a comment.Jan 23 2023, 3:01 PM

Change 882187 merged by jenkins-bot:

[mediawiki/libs/less.php@master] Misc clean up around Less_Ruleset for readability and less.js parity

https://gerrit.wikimedia.org/r/882187

gerritbot added a comment.Feb 8 2023, 11:33 PM

Change 882188 merged by jenkins-bot:

[mediawiki/libs/less.php@master] Less_Ruleset: Fix support for nested parent selectors

https://gerrit.wikimedia.org/r/882188

gerritbot added a comment.Feb 9 2023, 12:13 AM

Change 887867 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] ResourceLoader: Update wikimedia/less.php to v3.2.1

https://gerrit.wikimedia.org/r/887867

gerritbot added a comment.Feb 13 2023, 1:07 AM

Change 887867 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Update wikimedia/less.php to v3.2.1

https://gerrit.wikimedia.org/r/887867

Maintenance_bot removed a project: Patch-For-Review.Feb 13 2023, 1:30 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.23; 2023-02-13).Feb 13 2023, 2:00 AM
Krinkle closed this task as Resolved.Feb 14 2023, 11:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits