Page MenuHomePhabricator
Create Task
Maniphest T204863

Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.32 release
Closed, ResolvedPublic
Actions

Description

Untracked work || T205029: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.33 release

This is a list of potential deprecated code to drop. Not all of it will be dropped before 1.32 (and we'll move entries to a parallel ticket for 1.33). Found by manually looking for hard deprecations; soft-deprecated code isn't listed here (yet?).

  • From 1.17
    • Nothing!
  • From 1.18
    • SpecialPageFactory – Array syntax for $wgSpecialPages
  • From 1.19
    • UnknownAction hook; no task for removal, but see T178844 for documentation.
  • From 1.21
    • Nothing!
  • From 1.22
    • ParserLimitReport hook
  • From 1.23
    • $wgLBFactoryConf support for values with underscores (LBFactory_Simple/LBFactory_Single/LBFactory_Multi)
    • The SpecialRecentChangesFilters and SpecialWatchlistFilters hooks
    • The SpecialRecentChangesQuery and SpecialWatchlistQuery hooks
  • From 1.24
    • MailAddress – Construction with a User object
  • From 1.25
    • wfErrorLog
    • wfRunHooks
    • The DoEditSectionLink hook
    • The UserGetImplicitGroups hook
  • From 1.26
    • wfUseMW
    • RestbaseVirtualRESTService and ParsoidVirtualRESTService::onParsoid1Request (defer to 1.33)
  • From 1.29
    • The ChangesListSpecialPageFilters hook
  • From 1.30
    • wfUsePHP
    • File / MediaHandler ::getStreamHeaders()

Details

SubjectRepoBranchLines +/-
Stop MailAddress accepting a User objectmediawiki/coremaster+6 -12
Drop support for array syntax for $wgSpecialPagesmediawiki/coremaster+1 -11
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Sep 19 2018, 6:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2018, 6:56 PM
Jdforrester-WMF updated the task description. (Show Details)Sep 19 2018, 7:08 PM
Jdforrester-WMF updated the task description. (Show Details)Sep 19 2018, 8:13 PM
Jdforrester-WMF renamed this task from Drop legacy deprecated code from MediaWiki ahead of MediaWiki 1.32 release to Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.32 release.Sep 19 2018, 8:15 PM
Jdforrester-WMF updated the task description. (Show Details)
MGChecker subscribed.Sep 19 2018, 11:00 PM
MGChecker updated the task description. (Show Details)Sep 19 2018, 11:14 PM
Aklapper added a comment.Sep 20 2018, 8:51 AM

Could this be split into subtasks with documentation how to find instances and turned into Google-Code-in-2018 tasks, maybe?

cscott subscribed.Sep 20 2018, 12:18 PM

Perhaps a separate task for "hard deprecate stuff which has been soft deprecated for a while"?

Anomie subscribed.Sep 20 2018, 1:50 PM

WikiPage – Calling ::prepareContentForEdit with a revisionid rather than a Revision object

I note the whole method is deprecated in 1.32. Although the replacement IMO should itself be deprecated in 1.33. Yay MCR?

EditPage::submit()

FYI, EditPage should be getting an overhaul soon for MCR stuff. Not sure to what extent that might change its public-facing interface.

Article::doEditContent() – T155696

I note the replacement, WikiPage::doEditContent(), is itself deprecated in 1.32. Although the replacement for WikiPage::doEditContent() IMO should itself be deprecated in 1.33. Yay MCR?

Jdforrester-WMF added a comment.Sep 20 2018, 3:16 PM
In T204863#4600770, @Aklapper wrote:

Could this be split into subtasks with documentation how to find instances and turned into Google-Code-in-2018 tasks, maybe?

It'd be a bit premature at this point; I made this task as a talking point to get agreement on what we should kill off. Maybe in a week's time we can pick which ones we're actually going to want to do and create those tasks, tagged as GCI?

Jdforrester-WMF mentioned this in T205029: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.33 release.Sep 20 2018, 8:40 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added a comment.Sep 20 2018, 8:42 PM

Per T199291#4416609, moved to 1.33.

gerritbot subscribed.Sep 20 2018, 10:58 PM

Change 461814 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Drop support for array sytnax for $wgSpecialPages

https://gerrit.wikimedia.org/r/461814

gerritbot added a project: Patch-For-Review.Sep 20 2018, 10:58 PM
Jdforrester-WMF removed a project: Patch-For-Review.Sep 21 2018, 12:03 AM
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.Sep 21 2018, 12:37 AM

Change 461814 merged by jenkins-bot:
[mediawiki/core@master] Drop support for array syntax for $wgSpecialPages

https://gerrit.wikimedia.org/r/461814

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Sep 21 2018, 1:00 AM
Reedy updated the task description. (Show Details)Sep 21 2018, 1:00 AM
gerritbot added a comment.Sep 21 2018, 1:13 AM

Change 461837 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Stop MailAddress accepting a User object

https://gerrit.wikimedia.org/r/461837

gerritbot added a project: Patch-For-Review.Sep 21 2018, 1:13 AM
Reedy updated the task description. (Show Details)Sep 21 2018, 1:26 AM
Reedy subscribed.

wfUseMW removed in https://github.com/wikimedia/mediawiki/commit/7e0bb365bb8b6cd9b9570526cf0ede71bc6ee2c1

"$wgLBFactoryConf support for values with underscores (LBFactory_Simple/LBFactory_Single/LBFactory_Multi)" - classes were removed in 1.23.. Nothing to do here?

gerritbot added a comment.Sep 21 2018, 2:44 AM

Change 461837 merged by jenkins-bot:
[mediawiki/core@master] Stop MailAddress accepting a User object

https://gerrit.wikimedia.org/r/461837

MGChecker updated the task description. (Show Details)Sep 21 2018, 7:29 AM
Jdforrester-WMF updated the task description. (Show Details)Sep 24 2018, 8:41 PM
cscott updated the task description. (Show Details)Sep 25 2018, 7:49 PM
Jdforrester-WMF updated the task description. (Show Details)Oct 2 2018, 12:40 AM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF updated the task description. (Show Details)Oct 2 2018, 1:13 AM
Jdforrester-WMF updated the task description. (Show Details)Oct 3 2018, 11:40 PM
Jdforrester-WMF removed a project: Patch-For-Review.Oct 5 2018, 10:41 PM
Legoktm moved this task from Backlog to Deprecations on the MW-1.32-release board.Oct 9 2018, 12:41 AM
Jdforrester-WMF updated the task description. (Show Details)Oct 10 2018, 11:52 PM
Jdforrester-WMF updated the task description. (Show Details)Oct 11 2018, 8:04 PM
Jdforrester-WMF closed this task as Resolved.Oct 11 2018, 8:07 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF updated the task description. (Show Details)

We've done all we'll get done. Rest moved to T205029.

Aklapper mentioned this in T206833: Remove usage of deprecated ParserLimitReport hook (removed in MediaWiki 1.32).Oct 12 2018, 4:15 AM
MGChecker reopened this task as Open.Oct 12 2018, 8:05 PM
MGChecker closed this task as a duplicate of T203015: [Loops] Fix usage of deprecated ParserLimitReport hook.

Shit.

Aklapper closed this task as Resolved.Oct 12 2018, 8:34 PM

Fixed, no worries. :)

MGChecker added a comment.Oct 12 2018, 9:48 PM
In T204863#4662406, @Aklapper wrote:

Fixed, no worries. :)

Thank you!

Izno subscribed.Oct 13 2018, 12:09 AM
In T204863#4662355, @MGChecker wrote:

Shit.

Welcome to Phabricator, where everything's made up and the swear words don't matter!

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL