Page MenuHomePhabricator

Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.32 release
Closed, ResolvedPublic

Description

Untracked work || T205029: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.33 release

This is a list of potential deprecated code to drop. Not all of it will be dropped before 1.32 (and we'll move entries to a parallel ticket for 1.33). Found by manually looking for hard deprecations; soft-deprecated code isn't listed here (yet?).

  • From 1.17
    • Nothing!
  • From 1.18
    • SpecialPageFactory – Array syntax for $wgSpecialPages
  • From 1.19
    • UnknownAction hook; no task for removal, but see T178844 for documentation.
  • From 1.21
    • Nothing!
  • From 1.22
    • ParserLimitReport hook
  • From 1.23
    • $wgLBFactoryConf support for values with underscores (LBFactory_Simple/LBFactory_Single/LBFactory_Multi)
    • The SpecialRecentChangesFilters and SpecialWatchlistFilters hooks
    • The SpecialRecentChangesQuery and SpecialWatchlistQuery hooks
  • From 1.24
    • MailAddress – Construction with a User object
  • From 1.25
    • wfErrorLog
    • wfRunHooks
    • The DoEditSectionLink hook
    • The UserGetImplicitGroups hook
  • From 1.26
    • wfUseMW
    • RestbaseVirtualRESTService and ParsoidVirtualRESTService::onParsoid1Request (defer to 1.33)
  • From 1.29
    • The ChangesListSpecialPageFilters hook
  • From 1.30
    • wfUsePHP
    • File / MediaHandler ::getStreamHeaders()

Event Timeline

Jdforrester-WMF renamed this task from Drop legacy deprecated code from MediaWiki ahead of MediaWiki 1.32 release to Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.32 release.Sep 19 2018, 8:15 PM
Jdforrester-WMF updated the task description. (Show Details)

Could this be split into subtasks with documentation how to find instances and turned into Google-Code-in-2018 tasks, maybe?

Perhaps a separate task for "hard deprecate stuff which has been soft deprecated for a while"?

WikiPage – Calling ::prepareContentForEdit with a revisionid rather than a Revision object

I note the whole method is deprecated in 1.32. Although the replacement IMO should itself be deprecated in 1.33. Yay MCR?

EditPage::submit()

FYI, EditPage should be getting an overhaul soon for MCR stuff. Not sure to what extent that might change its public-facing interface.

Article::doEditContent() – T155696

I note the replacement, WikiPage::doEditContent(), is itself deprecated in 1.32. Although the replacement for WikiPage::doEditContent() IMO should itself be deprecated in 1.33. Yay MCR?

Could this be split into subtasks with documentation how to find instances and turned into Google-Code-in-2018 tasks, maybe?

It'd be a bit premature at this point; I made this task as a talking point to get agreement on what we should kill off. Maybe in a week's time we can pick which ones we're actually going to want to do and create those tasks, tagged as GCI?

Change 461814 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Drop support for array sytnax for $wgSpecialPages

https://gerrit.wikimedia.org/r/461814

Change 461814 merged by jenkins-bot:
[mediawiki/core@master] Drop support for array syntax for $wgSpecialPages

https://gerrit.wikimedia.org/r/461814

Change 461837 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Stop MailAddress accepting a User object

https://gerrit.wikimedia.org/r/461837

Reedy added a subscriber: Reedy.

wfUseMW removed in https://github.com/wikimedia/mediawiki/commit/7e0bb365bb8b6cd9b9570526cf0ede71bc6ee2c1

"$wgLBFactoryConf support for values with underscores (LBFactory_Simple/LBFactory_Single/LBFactory_Multi)" - classes were removed in 1.23.. Nothing to do here?

Change 461837 merged by jenkins-bot:
[mediawiki/core@master] Stop MailAddress accepting a User object

https://gerrit.wikimedia.org/r/461837

Jdforrester-WMF claimed this task.
Jdforrester-WMF updated the task description. (Show Details)

We've done all we'll get done. Rest moved to T205029.

Fixed, no worries. :)

Shit.

Welcome to Phabricator, where everything's made up and the swear words don't matter!