Maniphest T204867

Webpack + test transition of mobile.startup classes and instances (Button, Icon, icons, Panel, Section, Thumbnail, Page)
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Continue the migration of mobile.startup to webpack.

Acceptance criteria

Button built via webpack
Icon built via webpack
icons built via webpack
Panel built via webpack
Section built via webpack
Thumbnail built via webpack
Page built via webpack
After porting, update any global jQuery references to use the util.js module per our dev conversations

Note: Adding additional test coverage is out of scope and will be added separately.
Note: If tests cannot be ported (similar to View.js) due to reliance on sinon or jQuery leave them be. Only port the trivial tests.

Sign off steps

Measure and record code coverage on the wiki page

Details

Project	Branch	Lines +/-	Subject
mediawiki/extensions/MobileFrontend	master	+23 -20	Hygiene: replace $ with util.parseHTML in Page.test
mediawiki/extensions/MobileFrontend	master	+445 -390	Hygiene: enable headless Page tests
mediawiki/extensions/MobileFrontend	master	+950 -947	Hygiene: port widgets and models to Webpack
mediawiki/skins/MinervaNeue	master	+1 -1	Hygiene: access time via mfModules instead of M

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
Resolved	Jdlrobson	T195478 [EPIC] Speed up unit test execution and increase code coverage
Resolved	None	T204867 Webpack + test transition of mobile.startup classes and instances (Button, Icon, icons, Panel, Section, Thumbnail, Page)

Event Timeline

Jdlrobson created this task.Sep 19 2018, 7:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2018, 7:14 PM

Jdlrobson added a project: MobileFrontend (MobileFrontend and MinervaNeue architecture).Sep 19 2018, 7:14 PM

Jdlrobson updated the task description. (Show Details)Sep 24 2018, 5:31 PM

ovasileva triaged this task as High priority.Sep 25 2018, 4:20 PM

ovasileva set the point value for this task to 3.Sep 25 2018, 4:26 PM

ovasileva edited projects, added Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1); removed Readers-Web-Backlog.Sep 25 2018, 4:35 PM

Niedzielski claimed this task.Sep 27 2018, 8:54 PM

Niedzielski moved this task from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.

Change 463544 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Hygiene: port widgets to Webpack

https://gerrit.wikimedia.org/r/463544

Change 463545 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Hygiene: enable headless Page tests

https://gerrit.wikimedia.org/r/463545

Niedzielski removed Niedzielski as the assignee of this task.Sep 28 2018, 8:06 PM

Niedzielski moved this task from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.

Niedzielski added a subscriber: Niedzielski.

Change 463786 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] Hygiene: access time via mfModules instead of M

https://gerrit.wikimedia.org/r/463786

Jdlrobson moved this task from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Oct 1 2018, 10:44 PM

Change 463786 abandoned by Niedzielski:
Hygiene: access time via mfModules instead of M

https://gerrit.wikimedia.org/r/463786

Niedzielski moved this task from Needs More Work to Blocked on Others on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Oct 2 2018, 5:15 PM

ovasileva moved this task from Readers-Web-Kanbanana-Board-2018-19-Q1 to Readers-Web-Kanbanana-Board-2018-19-Q2 on the Readers-Web-Backlog board.Oct 2 2018, 5:29 PM

ovasileva edited projects, added Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1).

ovasileva moved this task from To Do to Blocked on Others on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 2 2018, 5:36 PM

Jdlrobson moved this task from Blocked on Others to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 3 2018, 10:32 PM

Jdlrobson moved this task from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 3 2018, 11:40 PM

Change 463544 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: port widgets and models to Webpack

https://gerrit.wikimedia.org/r/463544

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 4 2018, 4:00 PM

Jdlrobson updated the task description. (Show Details)Oct 5 2018, 6:12 PM

Jdlrobson moved this task from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 8 2018, 5:54 PM

Change 463545 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: enable headless Page tests

https://gerrit.wikimedia.org/r/463545

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 8 2018, 8:20 PM

Jdlrobson claimed this task.Oct 10 2018, 5:14 PM

Jdlrobson updated the task description. (Show Details)Oct 10 2018, 5:55 PM

1 acceptance criteria not done:
"After porting, update any global jQuery references to use the util.js module per our dev conversations"

What do we want to do here (if anything)

I see globals in:

tests/node-qunit/mobile.startup/Page.test.js
e.g. $( PARSER_OUTPUT ).html(
tests/node-qunit/mobile.startup/util.test.js
docReady instanceof $,
tests/node-qunit/mobile.startup/Browser.test.js
- $html = $( tmpDOM );
tests/node-qunit/mobile.startup/View.test.js
view.$el instanceof $

The View and util usages seem legit, but should we be using util.parseHTML instead for the others?

Niedzielski claimed this task.Oct 12 2018, 12:26 AM

Jdlrobson moved this task from Needs More Work to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 17 2018, 9:20 PM

Change 468347 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Hygiene: replace $ with util.parseHTML in Page.test

https://gerrit.wikimedia.org/r/468347

instanceof $
$html = $( tmpDOM );

I wasn't sure what to do with this one since we don't have a util method for these. Since it was unusual and not part of this task's tests, I left it.

I've made all util.parseHTML() substitutions in Page.test.js.

Jdlrobson moved this task from Doing to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 18 2018, 4:19 PM

Jdlrobson added a parent task: T195478: [EPIC] Speed up unit test execution and increase code coverage.Oct 18 2018, 4:36 PM

Jdlrobson moved this task from Ready for Signoff to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 18 2018, 4:41 PM

Jdlrobson moved this task from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 18 2018, 4:59 PM

Jdlrobson moved this task from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 18 2018, 9:37 PM

Change 468347 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: replace $ with util.parseHTML in Page.test

https://gerrit.wikimedia.org/r/468347

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 19 2018, 6:41 PM

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.1; 2018-10-23).Oct 19 2018, 7:01 PM

Niedzielski removed Niedzielski as the assignee of this task.Oct 19 2018, 7:11 PM

Niedzielski removed a subscriber: Niedzielski.