Page MenuHomePhabricator
Create Task
Maniphest T204867

Webpack + test transition of mobile.startup classes and instances (Button, Icon, icons, Panel, Section, Thumbnail, Page)
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Continue the migration of mobile.startup to webpack.

Acceptance criteria

  • Button built via webpack
  • Icon built via webpack
  • icons built via webpack
  • Panel built via webpack
  • Section built via webpack
  • Thumbnail built via webpack
  • Page built via webpack
  • After porting, update any global jQuery references to use the util.js module per our dev conversations

Note: Adding additional test coverage is out of scope and will be added separately.
Note: If tests cannot be ported (similar to View.js) due to reliance on sinon or jQuery leave them be. Only port the trivial tests.

Sign off steps

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+23 -20Hygiene: replace $ with util.parseHTML in Page.test
mediawiki/extensions/MobileFrontendmaster+445 -390Hygiene: enable headless Page tests
mediawiki/extensions/MobileFrontendmaster+950 -947Hygiene: port widgets and models to Webpack
mediawiki/skins/MinervaNeuemaster+1 -1Hygiene: access time via mfModules instead of M
Customize query in gerrit

Related Objects
Search...

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2018, 7:14 PM
Jdlrobson updated the task description. (Show Details)Sep 24 2018, 5:31 PM
ovasileva triaged this task as High priority.Sep 25 2018, 4:20 PM
ovasileva set the point value for this task to 3.Sep 25 2018, 4:26 PM
gerritbot added a subscriber: gerritbot.Sep 28 2018, 8:04 PM

Change 463544 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Hygiene: port widgets to Webpack

https://gerrit.wikimedia.org/r/463544

gerritbot added a project: Patch-For-Review.Sep 28 2018, 8:04 PM

Change 463545 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Hygiene: enable headless Page tests

https://gerrit.wikimedia.org/r/463545

gerritbot added a comment.Oct 1 2018, 3:24 PM

Change 463786 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] Hygiene: access time via mfModules instead of M

https://gerrit.wikimedia.org/r/463786

gerritbot added a comment.Oct 2 2018, 3:34 PM

Change 463786 abandoned by Niedzielski:
Hygiene: access time via mfModules instead of M

https://gerrit.wikimedia.org/r/463786

gerritbot added a comment.Oct 4 2018, 3:07 PM

Change 463544 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: port widgets and models to Webpack

https://gerrit.wikimedia.org/r/463544

Jdlrobson updated the task description. (Show Details)Oct 5 2018, 6:12 PM
gerritbot added a comment.Oct 8 2018, 7:52 PM

Change 463545 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: enable headless Page tests

https://gerrit.wikimedia.org/r/463545

Jdlrobson updated the task description. (Show Details)Oct 10 2018, 5:55 PM
Jdlrobson moved this task from Ready for Signoff to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 10 2018, 6:03 PM

1 acceptance criteria not done:
"After porting, update any global jQuery references to use the util.js module per our dev conversations"

What do we want to do here (if anything)

I see globals in:

  • tests/node-qunit/mobile.startup/Page.test.js
  • e.g. $( PARSER_OUTPUT ).html(
  • tests/node-qunit/mobile.startup/util.test.js
  • docReady instanceof $,
  • tests/node-qunit/mobile.startup/Browser.test.js
    • $html = $( tmpDOM );
  • tests/node-qunit/mobile.startup/View.test.js
  • view.$el instanceof $

The View and util usages seem legit, but should we be using util.parseHTML instead for the others?

gerritbot added a comment.Oct 18 2018, 3:57 PM

Change 468347 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Hygiene: replace $ with util.parseHTML in Page.test

https://gerrit.wikimedia.org/r/468347

Niedzielski added a comment.Oct 18 2018, 3:59 PM

instanceof $
$html = $( tmpDOM );

I wasn't sure what to do with this one since we don't have a util method for these. Since it was unusual and not part of this task's tests, I left it.

I've made all util.parseHTML() substitutions in Page.test.js.

gerritbot added a comment.Oct 19 2018, 6:40 PM

Change 468347 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: replace $ with util.parseHTML in Page.test

https://gerrit.wikimedia.org/r/468347

Niedzielski removed Niedzielski as the assignee of this task.Oct 19 2018, 7:11 PM
Niedzielski removed a subscriber: Niedzielski.
Niedzielski added a subscriber: Niedzielski.
Jdlrobson closed this task as Resolved.Oct 19 2018, 9:18 PM
Jdlrobson updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL