Page MenuHomePhabricator

Incubator emits "PHP Notice: Undefined index: realtitle"
Closed, ResolvedPublic

Description

Error

Request ID: W6KtvwrAIDMAACkj8C0AAAAQ

message
[{exception_id}] {exception_url}   ErrorException from line 607 of /srv/mediawiki/php-1.32.0-wmf.22/extensions/WikimediaIncubator/WikimediaIncubator.class.php: PHP Notice: Undefined index: realtitle
stacktrace
#1 /srv/mediawiki/php-1.32.0-wmf.22/includes/Hooks.php(174): WikimediaIncubator::onShowMissingArticle(Article)
#2 /srv/mediawiki/php-1.32.0-wmf.22/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#3 /srv/mediawiki/php-1.32.0-wmf.22/includes/page/Article.php(1390): Hooks::run(string, array)
#4 /srv/mediawiki/php-1.32.0-wmf.22/includes/page/Article.php(681): Article->showMissingArticle()
#5 /srv/mediawiki/php-1.32.0-wmf.22/includes/actions/ViewAction.php(68): Article->view()
#6 /srv/mediawiki/php-1.32.0-wmf.22/includes/MediaWiki.php(501): ViewAction->show()
#7 /srv/mediawiki/php-1.32.0-wmf.22/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#8 /srv/mediawiki/php-1.32.0-wmf.22/includes/MediaWiki.php(868): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.32.0-wmf.22/includes/MediaWiki.php(525): MediaWiki->main()
#10 /srv/mediawiki/php-1.32.0-wmf.22/index.php(42): MediaWiki->run()

Notes

This is seem from a handful of Incubator page views, some of them in a pattern that (anonimised by using my own nick instead) look like https://incubator.wikimedia.org/wiki/User%2Btalk:Krinkle/XYZ.js/i18n.

The response looks erroneous, in that it is linking to a domain that does not exist: https://xyz.js.wikisource.org.

Event Timeline

Krinkle created this task.Sep 19 2018, 8:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2018, 8:50 PM

Still seen in prod on 1.34-wmf.10.

Krinkle triaged this task as Normal priority.Mon, Jun 24, 11:27 PM

Change 518845 had a related patch set uploaded (by Ebe123; owner: Ebe123):
[mediawiki/extensions/WikimediaIncubator@master] Add more stringent prefix analysis tests

https://gerrit.wikimedia.org/r/518845

Ebe123 claimed this task.Tue, Jun 25, 12:02 AM

Change 519464 had a related patch set uploaded (by Krinkle; owner: Ebe123):
[mediawiki/extensions/WikimediaIncubator@wmf/1.34.0-wmf.11] Add more stringent prefix analysis tests

https://gerrit.wikimedia.org/r/519464

Change 518845 merged by jenkins-bot:
[mediawiki/extensions/WikimediaIncubator@master] Add more stringent prefix analysis tests

https://gerrit.wikimedia.org/r/518845

Change 519464 merged by jenkins-bot:
[mediawiki/extensions/WikimediaIncubator@wmf/1.34.0-wmf.11] Add more stringent prefix analysis tests

https://gerrit.wikimedia.org/r/519464

Confirmed via mwdebug1002. In addition to there no longer being an application error triggered by the task scenario, the user is now also given the correct message "This page is unprefixed." on the page.

Krinkle closed this task as Resolved.Thu, Jun 27, 5:55 PM
Krinkle removed a project: Patch-For-Review.

Mentioned in SAL (#wikimedia-operations) [2019-06-27T17:55:11Z] <krinkle@deploy1001> Synchronized php-1.34.0-wmf.11/extensions/WikimediaIncubator/includes/WikimediaIncubator.php: T204883 / 93643b44a52ea7 (duration: 01m 00s)