Page MenuHomePhabricator

Wikibase related test errors for CirrusSearch blocking CX CI
Closed, ResolvedPublic

Description

See https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/17294/console for the patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/461614

There are 18 errors

Sample:

10:54:37 1) CirrusSearch\UpdaterTest::testDisplayTitle with data set "null when no display title is set" (null, Title Object (...), false)
10:54:37 Argument 3 passed to Wikibase\MediaInfo\WikibaseMediaInfoHooks::onCirrusSearchBuildDocumentParse() must be an instance of AbstractContent, null given
10:54:37 
10:54:37 /workspace/src/extensions/WikibaseMediaInfo/src/WikibaseMediaInfoHooks.php:354
10:54:37 /workspace/src/includes/Hooks.php:174
10:54:37 /workspace/src/includes/Hooks.php:202
10:54:37 /workspace/src/extensions/CirrusSearch/includes/Updater.php:369
10:54:37 /workspace/src/extensions/CirrusSearch/tests/phpunit/UpdaterTest.php:95
10:54:37 /workspace/src/tests/phpunit/MediaWikiTestCase.php:409
10:54:37 /workspace/src/maintena

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
santhosh triaged this task as Unbreak Now! priority.Sep 20 2018, 11:08 AM

Fixed, sorry about that and thanks for the @Cparle!