Page MenuHomePhabricator
Create Task
Maniphest T204954

Uncaught MWException: SpecialEditWatchlistTest::tearDown() must call parent::tearDown()
Closed, ResolvedPublicBUG REPORT
Actions

Description

Environments:

MW1.32.0-alpha (27cb4c5)
PHP7.2.9

Steps to Reproduce:

$ php tests/phpunit/phpunit.php

Actual Results:

...
ERRORS!
Tests: 21310, Assertions: 132825, Errors: 1076, Failures: 47, Warnings: 1, Skipped: 62, Risky: 1.
PHP Fatal error:  Uncaught MWException: SpecialEditWatchlistTest::tearDown() must call parent::tearDown() in /mediawiki/tests/phpunit/MediaWikiTestCase.php:143
Stack trace:
#0 [internal function]: MediaWikiTestCase->__destruct()
#1 {main}
  thrown in /mediawiki/tests/phpunit/MediaWikiTestCase.php on line 143
PHP Stack trace:
PHP   1. MWExceptionHandler::{closure:/mediawiki/includes/exception/MWExceptionHandler.php:126-128}() /mediawiki/includes/exception/MWExceptionHandler.php:0

Expected Code:
SpecialWatchlistTest class must have tearDown() method.

Details

SubjectRepoBranchLines +/-
Add SpecialWatchlistTest::tearDown() methodmediawiki/coreREL1_31+5 -0
Add SpecialWatchlistTest::tearDown() methodmediawiki/coreREL1_32+5 -0
Add SpecialEditWatchlistTest::tearDown() methodmediawiki/coremaster+3 -0
Customize query in gerrit

Related Objects

Event Timeline

RazeSoldier created this task.Sep 20 2018, 2:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 20 2018, 2:25 PM
RazeSoldier updated the task description. (Show Details)Sep 20 2018, 2:25 PM
RazeSoldier moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
RazeSoldier updated the task description. (Show Details)Sep 20 2018, 2:29 PM
RazeSoldier renamed this task from Uncaught MWException: SpecialEditWatchlistTest::tearDown() must call parent::tearDown() to PHPUnit test failed due missing SpecialWatchlistTest::tearDown().Sep 20 2018, 2:35 PM
gerritbot subscribed.Nov 5 2018, 12:03 PM

Change 471701 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/core@master] Add SpecialWatchlistTest::tearDown() method

https://gerrit.wikimedia.org/r/471701

gerritbot added a project: Patch-For-Review.Nov 5 2018, 12:03 PM
xSavitar claimed this task.Nov 5 2018, 12:03 PM
xSavitar triaged this task as Medium priority.
xSavitar added a project: User-xSavitar.
xSavitar moved this task from Backlog to Doing [WIP] on the User-xSavitar board.
gerritbot added a comment.Nov 5 2018, 12:10 PM

Change 471709 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/core@REL1_32] Add SpecialWatchlistTest::tearDown() method

https://gerrit.wikimedia.org/r/471709

gerritbot added a comment.Nov 5 2018, 12:12 PM

Change 471710 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/core@REL1_31] Add SpecialWatchlistTest::tearDown() method

https://gerrit.wikimedia.org/r/471710

xSavitar added a comment.Nov 5 2018, 12:13 PM

Patch up and also back-ported to REL1_32 and REL1_31 (just in case).

RazeSoldier added a comment.Nov 5 2018, 5:58 PM

I noticed the discussion in the patch. I want to report:

  1. This task title looks wrong, may be Uncaught MWException: SpecialEditWatchlistTest::tearDown() must call parent::tearDown() would be best, because the exception actually no interrupt test and just show text in the test report end.
  2. I can't reproduce this problem at the current HEAD commit (6ac8c49). But when I checkout to 27cb4c5, I can reproduce.
RazeSoldier updated the task description. (Show Details)Nov 5 2018, 5:59 PM
xSavitar renamed this task from PHPUnit test failed due missing SpecialWatchlistTest::tearDown() to PHPUnit test failed due missing SpecialEditWatchlistTest::tearDown().Nov 5 2018, 6:03 PM
xSavitar renamed this task from PHPUnit test failed due missing SpecialEditWatchlistTest::tearDown() to Uncaught MWException: SpecialEditWatchlistTest::tearDown() must call parent::tearDown().
xSavitar updated the task description. (Show Details)
gerritbot added a comment.Nov 5 2018, 6:07 PM

Change 471701 abandoned by D3r1ck01:
Add SpecialWatchlistTest::tearDown() method

Reason:
I'll resurrect this patch when I have a better understanding of the issue (if no one has submitted a fix yet).

https://gerrit.wikimedia.org/r/471701

gerritbot added a comment.Nov 5 2018, 6:08 PM

Change 471701 restored by D3r1ck01:
Add SpecialWatchlistTest::tearDown() method

https://gerrit.wikimedia.org/r/471701

gerritbot added a comment.Nov 5 2018, 6:09 PM

Change 471701 abandoned by D3r1ck01:
Add SpecialEditWatchlistTest::tearDown() method

https://gerrit.wikimedia.org/r/471701

gerritbot added a comment.Nov 5 2018, 6:10 PM

Change 471709 abandoned by D3r1ck01:
Add SpecialWatchlistTest::tearDown() method

Reason:
Needs fix on master first.

https://gerrit.wikimedia.org/r/471709

gerritbot added a comment.Nov 5 2018, 6:10 PM

Change 471710 abandoned by D3r1ck01:
Add SpecialWatchlistTest::tearDown() method

Reason:
Needs fix on master first.

https://gerrit.wikimedia.org/r/471710

xSavitar removed xSavitar as the assignee of this task.Nov 5 2018, 6:11 PM
xSavitar moved this task from Doing [WIP] to Backlog on the User-xSavitar board.
xSavitar subscribed.
  1. I can't reproduce this problem at the current HEAD commit (6ac8c49). But when I checkout to 27cb4c5, I can reproduce.

27cb4c5 matches 1.32.0-alpha so it seems this issue happens from 1.32 and below? Will double check before attempting again. :)

Daimona subscribed.Nov 5 2018, 8:00 PM

Just a note: this failure is often seen when something abruptly halts the script. It could be due to something happening elsewhere.

xSavitar removed projects: User-xSavitar, Patch-For-Review.Nov 5 2018, 8:23 PM
RazeSoldier added a comment.Nov 7 2018, 10:12 AM

For my test (run P7769), I find 0c4b5ca fix this problem.

xSavitar added a comment.Nov 7 2018, 10:14 AM

So in that case, I guess maybe that change (0c4b5ca) should be back-ported to REL1_32 if necessary and other versions too?

RazeSoldier added a comment.Nov 7 2018, 10:36 AM

9fbbce85 already include in REL1_32. I don't know why this will fix the problem. But the problem has actually been solved, so we should mark this task as resolved.

RazeSoldier added a comment.Nov 7 2018, 3:09 PM

Also REL1_31 without this problem.

RazeSoldier closed this task as Resolved.Nov 8 2018, 2:30 PM
RazeSoldier claimed this task.
RazeSoldier removed RazeSoldier as the assignee of this task.Jan 23 2019, 7:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL