Page MenuHomePhabricator
Create Task
Maniphest T204956

ORES should return 429 instead of 408 in case of too many requests
Closed, ResolvedPublic
Actions

Description

As pointed out in https://lists.wikimedia.org/pipermail/wikitech-l/2018-September/090838.html

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Bump ORES to HEADLadsgroupmediawiki/services/ores/deploymaster+1 -1
Return 429 instead of 408 in case of too many requestsLadsgroupscoring/ores/oresmaster+37 -3
Customize query in gerrit

Related Objects

Event Timeline

Ladsgroup created this task.Sep 20 2018, 2:27 PM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptSep 20 2018, 2:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Sep 20 2018, 3:16 PM

Change 461656 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[scoring/ores/ores@master] Return 429 instead of 408 in case of too many requests

https://gerrit.wikimedia.org/r/461656

gerritbot added a project: Patch-For-Review.Sep 20 2018, 3:16 PM

Change 461656 abandoned by Ladsgroup:
Return 429 instead of 408 in case of too many requests

Reason:
wrong repo!

https://gerrit.wikimedia.org/r/461656

Ladsgroup mentioned this in rORESa0ca549dbf35: Return 429 instead of 408 in case of too many requests.Sep 20 2018, 3:20 PM
Ladsgroup added a comment.Sep 20 2018, 3:20 PM

https://github.com/wikimedia/ores/pull/263/files

Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Sep 20 2018, 3:21 PM
Krinkle awarded a token.Sep 20 2018, 4:14 PM
awight mentioned this in rORES8d6a4d3d1a8b: Return 429 instead of 408 in case of too many requests (#263).Sep 20 2018, 4:42 PM
gerritbot added a comment.Sep 20 2018, 4:47 PM

Change 461687 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/services/ores/deploy@master] Bump ORES to HEAD

https://gerrit.wikimedia.org/r/461687

Ladsgroup mentioned this in rORESDEPLOYee2d28bcc0cc: Bump ORES to HEAD.Sep 20 2018, 4:48 PM
gerritbot added a comment.Sep 20 2018, 4:49 PM

Change 461687 merged by Ladsgroup:
[mediawiki/services/ores/deploy@master] Bump ORES to HEAD

https://gerrit.wikimedia.org/r/461687

Stashbot subscribed.Sep 20 2018, 5:03 PM

Mentioned in SAL (#wikimedia-operations) [2018-09-20T17:03:22Z] <ladsgroup@deploy1001> Started deploy [ores/deploy@ee2d28b]: Returning 429 instead of 408 in case of too many requests (T204956)

Stashbot added a comment.Sep 20 2018, 5:24 PM

Mentioned in SAL (#wikimedia-operations) [2018-09-20T17:24:37Z] <ladsgroup@deploy1001> Finished deploy [ores/deploy@ee2d28b]: Returning 429 instead of 408 in case of too many requests (T204956) (duration: 21m 15s)

Ladsgroup moved this task from Review to Completed on the Machine-Learning-Team (Active Tasks) board.Sep 20 2018, 5:28 PM
Ladsgroup moved this task from Incoming to Blocked on others on the User-Ladsgroup board.Oct 2 2018, 8:19 PM
Ladsgroup moved this task from Blocked on others to Done on the User-Ladsgroup board.
Ladsgroup closed this task as Resolved.Nov 1 2018, 7:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits