Page MenuHomePhabricator
Create Task
Maniphest T204988

Add tests for NamespaceRestriction enforcement
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Add some tests to ensure the enforcement works correctly on Namespace.

The "blocked" message can be the same for PageRestriction and NamespaceRestriction.

Future messaging concerns:
Mobile Web can show the same "blocked" message for PageRestriction or NamespaceRestriction.
In the future, we may make the Web version give the user more specific information.

Things to Ensure:

  1. If User:Apples is blocked from User_talk then the Prevent this user from editing their own talk page while blocked takes precedence regardless if it is true or false

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Ensure that namespace blocking is enforced.Dbarrattmediawiki/coremaster+58 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

dbarratt created this task.Sep 20 2018, 5:52 PM
• TBolliger moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment-Team board.Sep 20 2018, 6:12 PM
• aezell renamed this task from Enforce namespace blocks from database and update block notices to Add tests for NamespaceRestriction enforcement.Sep 21 2018, 6:29 PM
• aezell updated the task description. (Show Details)
• aezell set the point value for this task to 2.
• TBolliger moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment-Team board.Sep 21 2018, 6:32 PM
dbarratt renamed this task from Add tests for NamespaceRestriction enforcement to Update partial block enforcement for Namespaces.Oct 15 2018, 8:19 PM
dbarratt updated the task description. (Show Details)Oct 15 2018, 8:23 PM
dbarratt renamed this task from Update partial block enforcement for Namespaces to Add tests for NamespaceRestriction enforcement.Oct 15 2018, 8:25 PM
• TBolliger added a comment.Oct 15 2018, 10:50 PM

Here are some:

  1. If User:Apples does not have permissions on edit a specific namespace (e.g. MediaWiki:) a block against that namespace should have no effect.
  2. Namespace blocks should prohibit page renames within the namespace
  3. Namespace blocks should prohibit page creations within the namespace
  4. Namespace blocks should prohibit page renames into or out of the namespace — may be handled in T197621
• TBolliger moved this task from Backlog to User blocking on the MediaWiki-User-management board.Nov 2 2018, 4:15 PM
dbarratt claimed this task.Nov 23 2018, 11:15 PM
dbarratt moved this task from Cards ready for development to AHT Sprint 33 on the Anti-Harassment-Team board.
dbarratt edited projects, added: Anti-Harassment-Team (AHT Sprint 33); removed: Anti-Harassment-Team.
dbarratt moved this task from Ready to In progress on the Anti-Harassment-Team (AHT Sprint 33) board.
gerritbot subscribed.Nov 26 2018, 4:44 PM

Change 475786 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/core@master] Ensure that namespace blocking is enforced.

https://gerrit.wikimedia.org/r/475786

gerritbot added a project: Patch-For-Review.Nov 26 2018, 4:44 PM
• TBolliger moved this task from AHT Sprint 33 to AHT Sprint 34 on the Anti-Harassment-Team board.Nov 26 2018, 8:32 PM
• TBolliger edited projects, added: Anti-Harassment-Team (AHT Sprint 34); removed: Anti-Harassment-Team (AHT Sprint 33).
• TBolliger moved this task from Ready to In progress on the Anti-Harassment-Team (AHT Sprint 34) board.
dbarratt updated the task description. (Show Details)Nov 27 2018, 5:42 AM
gerritbot added a comment.Nov 27 2018, 6:27 AM

Change 475786 abandoned by Dbarratt:
Ensure that namespace blocking is enforced.

https://gerrit.wikimedia.org/r/475786

dbarratt removed dbarratt as the assignee of this task.Nov 27 2018, 6:27 AM
dbarratt moved this task from In progress to Ready on the Anti-Harassment-Team (AHT Sprint 34) board.
dbarratt updated the task description. (Show Details)Nov 27 2018, 2:49 PM
dbarratt mentioned this in T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks).Nov 27 2018, 2:51 PM
• TBolliger edited projects, added: Anti-Harassment-Team (AHT Sprint 35); removed: Anti-Harassment-Team (AHT Sprint 34).Dec 5 2018, 8:06 PM
• dmaza moved this task from Ready to Review on the Anti-Harassment-Team (AHT Sprint 35) board.Dec 13 2018, 4:46 AM
dbarratt added a subscriber: • dmaza.Dec 21 2018, 1:47 AM

@dmaza Does anything need to be done here?

• TBolliger edited projects, added: Anti-Harassment-Team (Alef — א); removed: Anti-Harassment-Team (AHT Sprint 35).Jan 2 2019, 7:47 PM
• TBolliger moved this task from Ready to Review on the Anti-Harassment-Team (Alef — א) board.
• TBolliger edited projects, added: Anti-Harassment-Team (Bet — ב); removed: Anti-Harassment-Team (Alef — א).Jan 16 2019, 7:47 PM
• TBolliger moved this task from Ready to Review on the Anti-Harassment-Team (Bet — ב) board.
dbarratt closed this task as Resolved.Jan 23 2019, 5:39 PM
dbarratt moved this task from Review to Done on the Anti-Harassment-Team (Bet — ב) board.
dbarratt closed subtask T204990: Update Special:BlockList with namespace blocks as Resolved.Jan 23 2019, 6:50 PM
dbarratt closed subtask T204989: Update Block APIs to list namespace blocks as Resolved.Jan 24 2019, 12:43 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits