Page MenuHomePhabricator

Add tests for NamespaceRestriction enforcement
Closed, ResolvedPublic2 Estimated Story Points

Description

Add some tests to ensure the enforcement works correctly on Namespace.

The "blocked" message can be the same for PageRestriction and NamespaceRestriction.


Future messaging concerns:
Mobile Web can show the same "blocked" message for PageRestriction or NamespaceRestriction.
In the future, we may make the Web version give the user more specific information.


Things to Ensure:

  1. If User:Apples is blocked from User_talk then the Prevent this user from editing their own talk page while blocked takes precedence regardless if it is true or false

Event Timeline

aezell renamed this task from Enforce namespace blocks from database and update block notices to Add tests for NamespaceRestriction enforcement.Sep 21 2018, 6:29 PM
aezell updated the task description. (Show Details)
aezell set the point value for this task to 2.
dbarratt renamed this task from Add tests for NamespaceRestriction enforcement to Update partial block enforcement for Namespaces.Oct 15 2018, 8:19 PM
dbarratt renamed this task from Update partial block enforcement for Namespaces to Add tests for NamespaceRestriction enforcement.Oct 15 2018, 8:25 PM

Here are some:

  1. If User:Apples does not have permissions on edit a specific namespace (e.g. MediaWiki:) a block against that namespace should have no effect.
  2. Namespace blocks should prohibit page renames within the namespace
  3. Namespace blocks should prohibit page creations within the namespace
  4. Namespace blocks should prohibit page renames into or out of the namespace — may be handled in T197621

Change 475786 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/core@master] Ensure that namespace blocking is enforced.

https://gerrit.wikimedia.org/r/475786

Change 475786 abandoned by Dbarratt:
Ensure that namespace blocking is enforced.

https://gerrit.wikimedia.org/r/475786

dbarratt moved this task from In progress to Ready on the Anti-Harassment (AHT Sprint 34) board.

@dmaza Does anything need to be done here?

dbarratt moved this task from Review to Done on the Anti-Harassment (Bet — ב) board.