Page MenuHomePhabricator

scap clean not cleaning up deployment host fully
Open, NormalPublic

Description

It looks like for whatever reason, scap clean isn't cleaning the deployment up fully. It seems to be leaving /srv/mediawiki-staging/php-[version]/cache/l10n on disk, with nothing in it

rm -rf php-1.XX.X-wmf.X is enough to manually clean up...

Event Timeline

Reedy created this task.Sep 20 2018, 7:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 20 2018, 7:18 PM
thcipriani triaged this task as Normal priority.Sep 24 2018, 3:59 PM
thcipriani moved this task from Needs triage to Debt on the Scap board.
thcipriani added a subscriber: thcipriani.

That'll happen when you do a --delete, i.e. the branch directory will sit there empty until then next scap sync is run.

This is happening because the scap clean script is deleting the directory in /srv/mediawiki-staging on the deployment host, then syncing to all the other hosts as mwdeploy; however, the php-[version]/cache/l10n directory is not empty and is ignored (T157030). Now we go back as a final step and delete the dangling directories, but we don't delete their parent.

We could probably fix this by shifting some steps around in scap clean.

Reedy added a comment.Sep 24 2018, 4:01 PM

Those directories were still in /srv/mediawiki-staging on the deployment host, hence reporting the bug based on the investigation for T205000: Too many versions of MW core on deploy1001

Those directories were still in /srv/mediawiki-staging on the deployment host, hence reporting the bug based on the investigation for T205000: Too many versions of MW core on deploy1001

oh! is this task only referring to the deployment host and not the targets?

Reedy added a comment.Sep 24 2018, 5:51 PM

I think so, yeah. Didn't actually check the targets at the time, but the folders are definitely gone from /srv/mediawiki now too

thcipriani renamed this task from scap clean not cleaning up fully to scap clean not cleaning up deployment host fully.Sep 24 2018, 5:57 PM
thcipriani updated the task description. (Show Details)