Maniphest T205008

AMC: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

wgMinervaSchemaMainMenuClickTrackingSampleRate is currently set by default in Minerva as 0.5. It should be set as 0

Acceptance criteria

Write a patch for mediawiki-config to set in production to 0.5 and ask somebody to deploy that patch using the deployment calendar. During deployment you'll get a great experience of how we deploy config changes in Wikipedia. You will verify your change was successful by using X-Wikimedia-Debug. You'll want to check that for 50% of page views, clicking a link in the mobile main menu sends an event (see testing instructions)

☝️ @phuedx: Done in T205008#4776348. I've also tested the behaviour of the instrumentation in production 👍

When patch is merged write a patch for MobileFrontend to set the default to 0 and cleanup the related code (mw.config.get('wgMinervaSchemaMainMenuClickTrackingSampleRate',0.5) becomes mw.config.get('wgMinervaSchemaMainMenuClickTrackingSampleRate')

☝️ Done in T205008#4777333.

Testing steps

Open a new tab with mobile site
Open main menu
Open one of the many menu links in a new tab
Verify a beacon event shows in the developer console approx 50% of the time (see screenshot)

Screen Shot 2018-10-05 at 8.24.38 AM.png (685×928 px, 92 KB)

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/skins/MinervaNeue	master	+2 -3	Zero is a sensible default for this feature flag
	operations/mediawiki-config	master	+3 -0	Set wgMinervaSchemaMainMenuClickTrackingSampleRate

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Sep 20 2018, 7:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 20 2018, 7:57 PM

Jdlrobson triaged this task as Low priority.Sep 20 2018, 7:57 PM

Jdlrobson added a project: Readers-Web-Backlog.Sep 20 2018, 11:33 PM

Framawiki moved this task from Backlog to Config - to process on the Wikimedia-Site-requests board.Sep 21 2018, 7:02 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.Sep 25 2018, 10:15 PM

Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Readers-Web-Backlog board.

Jdlrobson added projects: Google-Code-in-2018, good first task.

Jdlrobson raised the priority of this task from Low to Medium.Oct 3 2018, 8:02 PM

Jdlrobson updated the task description. (Show Details)

@Jdlrobson: As a newcomer, I fail to find wgMFSchemaMainMenuClickTrackingSampleRate in the MobileFrontend codebase, so I'm wondering how to approach this task?

Amended!

https://codein.withgoogle.com/tasks/5513565575315456/
https://codein.withgoogle.com/tasks/5920649034858496/

Liuxinyu970226 added a subscriber: Liuxinyu970226.Oct 21 2018, 2:09 AM

(SWAT deploy)

Jdlrobson renamed this task from wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend to AMC: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend.Nov 15 2018, 6:58 PM

Jdlrobson moved this task from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 26 2018, 9:57 PM

Change 475882 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Set wgMinervaSchemaMainMenuClickTrackingSampleRate

https://gerrit.wikimedia.org/r/475882

gerritbot added a project: Patch-For-Review.Nov 26 2018, 9:59 PM

Change 475890 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Zero is a sensible default for this feature flag

https://gerrit.wikimedia.org/r/475890

SWAT scheduled. Once the SWAT has happened, follow up can be merged.

Change 475882 merged by jenkins-bot:
[operations/mediawiki-config@master] Set wgMinervaSchemaMainMenuClickTrackingSampleRate

https://gerrit.wikimedia.org/r/475882

Mentioned in SAL (#wikimedia-operations) [2018-11-27T00:17:27Z] <niharika29@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Set wgMinervaSchemaMainMenuClickTrackingSampleRate T205008 (duration: 00m 46s)

pmiazga removed a project: Patch-For-Review.Nov 27 2018, 1:54 AM

pmiazga moved this task from Needs Code Review to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

phuedx updated the task description. (Show Details)Nov 27 2018, 11:24 AM

phuedx added a subscriber: phuedx.

Change 475890 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Zero is a sensible default for this feature flag

https://gerrit.wikimedia.org/r/475890

phuedx updated the task description. (Show Details)Nov 27 2018, 12:53 PM

phuedx moved this task from Needs QA to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 27 2018, 1:00 PM

nray claimed this task.Nov 27 2018, 6:22 PM

Tested on https://en.m.wikipedia.org and we are still sending events at what seems like 50% of page views

nray closed this task as Resolved.Nov 27 2018, 8:27 PM

Aklapper removed a project: Google-Code-in-2018.Nov 27 2018, 10:03 PM

Liuxinyu970226 removed a subscriber: Liuxinyu970226.Dec 2 2018, 7:20 AM

	F26321553: Screen Shot 2018-10-05 at 8.24.38 AM.png
	Oct 5 2018, 3:26 PM

AMC: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontendClosed, ResolvedPublic1 Estimated Story PointsActions