Page MenuHomePhabricator
Create Task
Maniphest T205063

Merge WikibaseQuality and WikibaseQualityConstraints
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Move over classes from Wikibase Qualitymediawiki/extensions/WikibaseQualityConstraintsREL1_31+910 -32
Move over classes from Wikibase Qualitymediawiki/extensions/WikibaseQualityConstraintsmaster+927 -49
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore created this task.Sep 21 2018, 8:06 AM
gerritbot subscribed.Sep 21 2018, 8:06 AM

Change 460505 had a related patch set uploaded (by Addshore; owner: Jeroen De Dauw):
[mediawiki/extensions/WikibaseQualityConstraints@master] Move over classes from Wikibase Quality

https://gerrit.wikimedia.org/r/460505

gerritbot added a project: Patch-For-Review.Sep 21 2018, 8:06 AM
Addshore added a parent task: T205064: Stop loading WikibaseQuality extension on WMF sites.Sep 21 2018, 8:09 AM
Addshore triaged this task as Medium priority.Sep 21 2018, 8:12 AM
Addshore moved this task from incoming to in progress on the Wikidata board.Sep 21 2018, 8:29 AM
Addshore assigned this task to JeroenDeDauw.Sep 21 2018, 8:36 AM
gerritbot added a comment.Sep 24 2018, 6:46 PM

Change 460505 merged by Jeroen De Dauw:
[mediawiki/extensions/WikibaseQualityConstraints@master] Move over classes from Wikibase Quality

https://gerrit.wikimedia.org/r/460505

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Sep 24 2018, 7:00 PM
Addshore closed this task as Resolved.Oct 11 2018, 1:01 PM

the change has been merged and is also deployed in production

Lucas_Werkmeister_WMDE mentioned this in T206205: WBQC_ResultsSource ConstraintsServices not tested in CI for WikibaseQualityConstraints.Oct 19 2018, 12:13 PM
Tarrow reopened this task as Open.Oct 19 2018, 2:04 PM
Tarrow subscribed.

Looks like at least some of the HTML classes weren't changed over: see e.g. WikibaseQuality\Html\HtmlTableBuilder still present on extensions/WikibaseQualityConstraints/src/Specials/SpecialConstraintReport.php#38

This should have been caught by the tests but apparently not. I'm looking into that as part of T206205

Tarrow closed this task as Resolved.Oct 23 2018, 11:34 AM
Tarrow moved this task from Backlog to DONE on the Wikibase-Quality board.
Legoktm closed subtask T207655: WikibaseQualityConstraints and Wikibase CI Job shouldn't load WikibaseQuality as Resolved.Oct 29 2018, 10:57 PM
hashar mentioned this in T206670: 1.33.0-wmf.16 deployment blockers.Feb 4 2019, 11:40 AM
gerritbot added a comment.Jul 24 2020, 2:29 AM

Change 615860 had a related patch set uploaded (by Reedy; owner: Jeroen De Dauw):
[mediawiki/extensions/WikibaseQualityConstraints@REL1_31] Move over classes from Wikibase Quality

https://gerrit.wikimedia.org/r/615860

Reedy subscribed.Jul 24 2020, 2:44 AM

This left quite a mess behind, as seen in T258734: 220 test errors apparently in Wikibase related extensions in 1.31 for MW-1.31-release

gerritbot added a comment.Jul 24 2020, 2:45 AM

Change 615860 merged by Reedy:
[mediawiki/extensions/WikibaseQualityConstraints@REL1_31] Move over classes from Wikibase Quality

https://gerrit.wikimedia.org/r/615860

Reedy added a comment.Jul 24 2020, 2:47 AM
This comment was removed by Reedy.
Maintenance_bot removed a project: Patch-For-Review.Jul 24 2020, 3:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL