Page MenuHomePhabricator
Create Task
Maniphest T205096

DimensionWidget in a FieldLayout always disables the FieldLayout
Closed, ResolvedPublic
Actions

Description

Same as T203889, but for dimensions widget (used in maps dialog):

Screen Shot 2018-09-20 at 3.07.28 PM.png (490×792 px, 77 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (7c9ceb939)mediawiki/extensions/VisualEditormaster+21 -7
Call parent in DimensionsWidget#setDisabledVisualEditor/VisualEditormaster+7 -4
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Sep 21 2018, 2:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2018, 2:16 PM
gerritbot subscribed.Sep 21 2018, 2:16 PM

Change 461964 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Call parent in DimensionsWidget#setDisabled

https://gerrit.wikimedia.org/r/461964

gerritbot added a project: Patch-For-Review.Sep 21 2018, 2:17 PM
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Sep 21 2018, 2:17 PM
gerritbot added a comment.Sep 23 2018, 7:02 PM

Change 461964 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Call parent in DimensionsWidget#setDisabled

https://gerrit.wikimedia.org/r/461964

gerritbot added a comment.Sep 23 2018, 8:53 PM

Change 462321 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7c9ceb939)

https://gerrit.wikimedia.org/r/462321

gerritbot added a comment.Sep 23 2018, 9:42 PM

Change 462321 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7c9ceb939)

https://gerrit.wikimedia.org/r/462321

Jdforrester-WMF edited projects, added Maps (Kartographer), MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)); removed Patch-For-Review.Sep 24 2018, 3:06 PM
Jdforrester-WMF moved this task from Code review to QA on the VisualEditor (Current work) board.
MSantos moved this task from Unsorted to Tracking on the Maps (Kartographer) board.Sep 24 2018, 6:56 PM
Ryasmeen added a project: Verified.Sep 28 2018, 10:12 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
• Deskana closed this task as Resolved.Oct 1 2018, 2:55 PM
• Deskana triaged this task as Medium priority.
• Deskana added a project: Editing Q1 2018-19 mobile improvements.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL