Page MenuHomePhabricator
Create Task
Maniphest T205134

Contacts and Imported gifts going straight to trash after import
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Please bear with me as I explain this :)

Last week Leanne and I found a gift that had come through the Engage import files that somehow didn't actually make it into Civi. The import created the new donor and logged the contribution and then deleted the entire record. I restored it and the reporting numbers looked great. The only reason we found it was because it was over $1K and we always go back and look at these after import.

I just imported this week's engage file and the only $1K gift we had made into civi - no problem. So instead I did a Contact search selecting "Search in Trash" and contribution dates 8/27/18- now.
This returned 7 donors -
5 being contributions I had just imported the others are recurring donors.
It looks like it imported it, merged the record, but didn't move the new gift over. This is the ID for the records that stayed in Civi 14650205, 14129019, 22652379, 10445129 - they are both missing the gift I just imported. This one is not in civi at all 10816511.
Also, the import said successful.

Details

SubjectRepoBranchLines +/-
Ensure we're not matching on deleted contactswikimedia/fundraising/crmmaster+42 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

NNichols created this task.Sep 21 2018, 6:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2018, 6:36 PM
NNichols triaged this task as High priority.Sep 21 2018, 6:36 PM
NNichols updated the task description. (Show Details)
NNichols updated the task description. (Show Details)
Ejegg subscribed.Sep 21 2018, 7:49 PM

@NNichols can you put the original import files up on the fileshare?

• LeanneS added a comment.Sep 21 2018, 8:12 PM

@Ejegg I just placed the latest files on the server: Tech/Major Gifts/Engage Import/Trashed donations

Ejegg added a comment.Sep 21 2018, 8:47 PM

So it looks like CID 10816511 has been deleted for as long as we've been logging changes, but somehow the import decided to match on that. Donation ID 30651458 has a single log entry, showing it was inserted against that contact ID (When a donation is merged from one contact to another, it gets an 'Update' log entry showing the change in contact_id).

But as far as I know, the Engage import shouldn't be trying to match on existing donors at all... It's only Benevity that tries to match existing donors, right?

Ejegg added a project: Fundraising Sprint Sasquatches can't find us either.Sep 22 2018, 1:22 AM
gerritbot subscribed.Sep 22 2018, 3:47 AM

Change 462044 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Ensure we're not matching on deleted contacts

https://gerrit.wikimedia.org/r/462044

gerritbot added a project: Patch-For-Review.Sep 22 2018, 3:47 AM
Ejegg added a comment.Sep 22 2018, 3:48 AM

Ooh, the Engage import DOES match existing donors... I think that patch should help, but I'll do some more testing Monday.

• DStrine moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Sep 24 2018, 7:36 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Sasquatches can't find us either board.Sep 24 2018, 8:26 PM
gerritbot added a comment.Sep 25 2018, 1:16 AM

Change 462044 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Ensure we're not matching on deleted contacts

https://gerrit.wikimedia.org/r/462044

Ejegg moved this task from Doing to Done on the Fundraising Sprint Sasquatches can't find us either board.Sep 25 2018, 3:22 AM
Ejegg added a comment.Sep 25 2018, 3:15 PM

Ok @NNichols and @LeanneS , there's a fix up for both Benevity and Engage imports so they should never match on deleted contacts. Please let us know if you want tech to help with restoring any of the old donations imported against deleted contacts.

NNichols added a comment.Sep 25 2018, 7:52 PM

I was able to restore all of the gifts that came from engage but if I run the same search going back to 1/1/2016 there are about 282 contacts in the trash. Not sure how we would go through these to see which ones need to be restored.

Eileenmcnaughton added a comment.Oct 1 2018, 11:56 PM

@NNichols I added a follow on subtask for the other ones. T205941 - this is maybe closable now ?

NNichols added a comment.Oct 2 2018, 2:52 AM

Yes I saw the subtask. I think this is closable.

Eileenmcnaughton closed this task as Resolved.Oct 2 2018, 3:01 AM
Eileenmcnaughton claimed this task.
Eileenmcnaughton set the point value for this task to 2.Jun 27 2019, 5:50 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL