Page MenuHomePhabricator
Create Task
Maniphest T205154

The text displays one line above the cursor when syntax highlighting in while using the 2017 wikitext editor
Closed, ResolvedPublic
Actions

Description

As shown by the cursor and red spell check lines on the attached image, they are one line below the text. This only happens when syntax highlighting is turned on.

Screenshot (10).png (1×2 px, 439 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ve.ui.CodeMirror: Fix padding to match VisualEditor's paddingmediawiki/extensions/CodeMirrormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Daylen created this task.Sep 21 2018, 8:16 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptSep 21 2018, 8:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Schnark edited projects, added Timeless, MediaWiki-extensions-CodeMirror; removed SyntaxHighlight.Sep 22 2018, 8:49 AM
Schnark subscribed.

I can reproduce with Timeless skin, but not with Vector.

Restricted Application added a project: Community-Tech. · View Herald TranscriptSep 22 2018, 8:49 AM
Izno subscribed.Sep 22 2018, 1:29 PM

I can produce this on Firefox 62.0 64-bit on Windows 10.

Esanders subscribed.EditedSep 23 2018, 10:56 PM

Timeless is not an officially supported skin, but community patches are welcome.

matmarex claimed this task.Sep 27 2018, 7:59 PM
matmarex mentioned this in T205658: Editing caret is off by several pixels in VisualEditor wikitext editor..
gerritbot subscribed.Sep 27 2018, 8:06 PM

Change 463366 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/CodeMirror@master] ve.ui.CodeMirror: Fix padding to match VisualEditor's padding

https://gerrit.wikimedia.org/r/463366

gerritbot added a project: Patch-For-Review.Sep 27 2018, 8:06 PM
gerritbot added a comment.Sep 27 2018, 9:49 PM

Change 463366 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] ve.ui.CodeMirror: Fix padding to match VisualEditor's padding

https://gerrit.wikimedia.org/r/463366

matmarex closed this task as Resolved.Sep 27 2018, 9:51 PM
matmarex removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 27 2018, 9:51 PM
Liuxinyu970226 moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.Nov 21 2018, 2:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits