Page MenuHomePhabricator

div.patrollink in monobook should not be set to clear:both
Open, Needs TriagePublic

Description

div.patrollink {clear: both;} was added to Monobook's skin way back in 2008 via T14857 (commit rMW01eb893b778d) - and still seems to be there, in the 'skins.monobook.responsive' module. This is causing problems on Commons with the infobox, see the discussions at:

and an old screenshot at:
https://commons.wikimedia.org/wiki/File:Patrol_link_bug.jpg

and newer screenshots here (Vector 2022, equally broken):

Page with no review button, gallery starts at topPage with a review button, gallery starts below fold
Screenshot 2026-09-18 at 18-07-44 Category Doon Presbyterian Church (Kitchener Ontario) - Wikimedia Commons.png (1,920×1,583 px, 463 KB)
Screenshot 2026-09-18 at 18-07-20 Category Doon Presbyterian Church (Kitchener Ontario) - Wikimedia Commons.png (1,920×1,977 px, 486 KB)

Can it be removed, or is it still needed?

Event Timeline

Jdlrobson edited projects, added: MonoBook (Tracking); removed: MonoBook.

I wonder if this can be fixed by changing both to right.

No, it can’t. The problem is exactly that the right side is too long, so clear:right would still push down the button, and with that, the category content as well. I added two screenshots to the task description, hopefully they make the problem clearer. (Note that I used Save full page in Firefox to make the screenshots; the visible part of the page ends on my screen between the coordinates link and the Authority file heading of the infobox, everything below that is invisible without scrolling.)