Page MenuHomePhabricator

Many services in GenericServices are not actually that generic.
Closed, InvalidPublic

Description

Any service in GenericServices that use configuration values are not generic and need to be set up per repository and the configurations can change.

This was identified while trying to use an EntityTitleLookup in a WikiPageEntityMetaDataAccessor instance created in PerRepositoryServiceWiring and then trying to decide where to put it.

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptSep 24 2018, 11:40 AM

I expect this will end up being tackled as part of federated properties.

I'm just going to leave this to be tackled by federated properties..

From the task inspection...

First task could be:

  • (TASK) Investigate which of the GenericServices are actually generic vs those that are not
  • (Tasks for after investigation) Make tasks for moving the services that are not generic from GenericServices into SingleEntitySourceServices etc

Do we actually have multiple instances of this GenericServices in use?

  • No

Notes:

  • Less about side effects, more if the services should differ depending on the source (repo) of an entity
  • entitysources.md is a good read relating to the SingleEntitySourceServices and multiple entity source services classes etc.
Addshore edited projects, added wdwb-tech (legacy-backlog); removed wdwb-tech.
Addshore moved this task from Incoming to Stuck on the wdwb-tech (legacy-backlog) board.

Moving off the campsite board as this has been stuck for quite some time.