Maniphest T205268

Many services in GenericServices are not actually that generic.
Closed, InvalidPublic
Actions

Assigned To

None

Authored By

	Addshore
	Sep 24 2018, 11:40 AM

Description

Any service in GenericServices that use configuration values are not generic and need to be set up per repository and the configurations can change.

This was identified while trying to use an EntityTitleLookup in a WikiPageEntityMetaDataAccessor instance created in PerRepositoryServiceWiring and then trying to decide where to put it.

Related Objects
Search...

Status	Assigned	Task
Invalid	None	T205268 Many services in GenericServices are not actually that generic.
Resolved	ItamarWMDE	T260163 Investigate which of the GenericServices are actually generic vs those that are not
Resolved	ItamarWMDE	T260426 Move `getEntityNamespaceLookup` from `GenericServices`
Invalid	WMDE-leszek	T260431 Move `getLanguageFallbackChainFactory` from `GenericServices`

Event Timeline

Addshore created this task.Sep 24 2018, 11:40 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2018, 11:40 AM

Addshore moved this task from incoming to needs discussion or investigation on the Wikidata board.Sep 26 2018, 7:41 AM

Addshore moved this task from Inbox to Legacy Inbox on the [DEPRECATED] wdwb-tech board.Oct 8 2018, 12:53 PM

Addshore added a project: Technical-Debt.Oct 31 2018, 4:46 PM

Addshore added a project: Wikidata-Trailblazing-Exploration.Jun 22 2019, 9:55 PM

Addshore claimed this task.Dec 3 2019, 3:50 PM

Addshore moved this task from Backlog to In Investigation (cost/impact) on the Wikidata-Trailblazing-Exploration board.

Restricted Application added a project: User-Addshore. · View Herald TranscriptDec 3 2019, 3:50 PM

Addshore moved this task from Unsorted 💣 to Active 🚁 on the User-Addshore board.Dec 20 2019, 10:05 AM

I expect this will end up being tackled as part of federated properties.

I'm just going to leave this to be tackled by federated properties..

Addshore mentioned this in T255078: Fatal "Managed to lookup EntityId but got an unexpected type for namespace" from Wikibase EntityLinkTargetEntityIdLookup.Jun 11 2020, 2:33 PM

Addshore mentioned this in T258323: Unable to set up move protection in ns:0 on Commons.Jul 24 2020, 12:48 PM

darthmon_wmde added a project: Wikidata-Campsite.Aug 4 2020, 12:11 PM

darthmon_wmde moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.

Addshore updated the task description. (Show Details)Aug 11 2020, 12:13 PM

Addshore moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Aug 11 2020, 12:17 PM

Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

From the task inspection...

First task could be:

(TASK) Investigate which of the GenericServices are actually generic vs those that are not
(Tasks for after investigation) Make tasks for moving the services that are not generic from GenericServices into SingleEntitySourceServices etc

Do we actually have multiple instances of this GenericServices in use?

Notes:

Less about side effects, more if the services should differ depending on the source (repo) of an entity
entitysources.md is a good read relating to the SingleEntitySourceServices and multiple entity source services classes etc.

Addshore mentioned this in T260163: Investigate which of the GenericServices are actually generic vs those that are not.Aug 11 2020, 4:36 PM

Addshore added a project: Story.

Addshore updated the task description. (Show Details)

Michael mentioned this in T259783: LanguageFallbackChain does not end in 'en' for language codes that are not a valid format.Aug 12 2020, 3:20 PM

ItamarWMDE claimed this task.Aug 12 2020, 4:01 PM

ItamarWMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

ItamarWMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 14 2020, 1:42 PM

ItamarWMDE moved this task from Peer Review to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

ItamarWMDE moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 14 2020, 1:47 PM

Addshore closed subtask T260163: Investigate which of the GenericServices are actually generic vs those that are not as Resolved.Aug 17 2020, 9:37 AM

ItamarWMDE removed ItamarWMDE as the assignee of this task.Aug 17 2020, 2:15 PM

ItamarWMDE moved this task from Peer Review to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.