Is something like this ok? Will create RTL and SVG files if you're happy with it.

In T205290#4632872, @Prtksxna wrote:

Is something like this ok? Will create RTL and SVG files if you're happy with it.

It'd be awesome if we can highlight that the icon lives in the editor toolbar. The puzzle piece icon size can be reduced - that should be fine. We can also show a popup depicting the editor dialog beneath it. What do you think?

You should play around with the feature to get a sense of it, if you haven't had a chance to yet. If you go to this page in the standard editor you should see a puzzle piece icon which activates the templatewizard.

Change 464090 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/TemplateWizard@master] Add BetaFeatures support

https://gerrit.wikimedia.org/r/464090

I've started the patch for this, but obviously the images in it need to be updated whenever they're available.

Do we add PNG and SVG versions (of the RTL and LTR screenshots)? Or just PNG?

In T205290#4637339, @Samwilson wrote:

I've started the patch for this, but obviously the images in it need to be updated whenever they're available.

Do we add PNG and SVG versions (of the RTL and LTR screenshots)? Or just PNG?

What do other extensions do? 🤔

And good point - @Prtksxna we would need an RTL version too. Nothing changes except for the background (wikipedia logo circle and sidebar move to the right). The puzzle piece icon is not flipped.

In T205290#4637367, @Niharika wrote:

In T205290#4637339, @Samwilson wrote:

I've started the patch for this, but obviously the images in it need to be updated whenever they're available.

Do we add PNG and SVG versions (of the RTL and LTR screenshots)? Or just PNG?

What do other extensions do? 🤔

Structured Discussions has only SVG - https://github.com/wikimedia/mediawiki-extensions-Flow/tree/master/images

And good point - @Prtksxna we would need an RTL version too. Nothing changes except for the background (wikipedia logo circle and sidebar move to the right). The puzzle piece icon is not flipped.

Yep, as I mentioned previously, I'll make the RTL version once we're happy with the design.

CX also has SVG only - https://github.com/wikimedia/mediawiki-extensions-ContentTranslation/tree/master/images
So having SVG only is probably okay.

In T205290#4634131, @Niharika wrote:

It'd be awesome if we can highlight that the icon lives in the editor toolbar. The puzzle piece icon size can be reduced - that should be fine. We can also show a popup depicting the editor dialog beneath it. What do you think?

Is something like this better?

You should play around with the feature to get a sense of it, if you haven't had a chance to yet. If you go to this page in the standard editor you should see a puzzle piece icon which activates the templatewizard.

Thanks, this was helpful!

In T205290#4645165, @Prtksxna wrote:

In T205290#4634131, @Niharika wrote:

It'd be awesome if we can highlight that the icon lives in the editor toolbar. The puzzle piece icon size can be reduced - that should be fine. We can also show a popup depicting the editor dialog beneath it. What do you think?

Is something like this better?

That looks fine to me. Let's get the SVG versions for this and move forward on this.

	LTR	RTL
SVG	betafeature-ltr-min.svg2 KBDownload	betafeature-rtl-min.svg1 KBDownload
PNG
Source	betafeature-ltr.sketch14 KBDownload	betafeature-rtl.sketch14 KBDownload

I am not sure if it is my screen or something else, but I am seeing a slight difference in the blue in the RTL and LTR versions. Do you see it too? Actually, I see it for all RTL versions for betafeatures icons. We can start using them (since we never seem them together anywhere), but I'll investigate what is going on here.

Yeah that's strange: they do look different, but from what I can see they've both got the same colour (#3366ccff).

I've added them to the patch. Looks good to me. Even if they are different, I don't think it matters too much.

When I use a color picker on the screen, it gives me #4775d1 for the LTR, and ##3366cc for the RTL one, so it seems to not just be an artifact of our eyes. It might be some weird way these two render, specifically, on Phab?

If the SVG is the exact same definition of color, we can upload that and then test the beta feature ltr/rtl and see if there's a significant difference there. It might be a fluke on how the PNGs were rendered in this specific case.

Ah, it seems there there is different nesting in the SVGs. The RTL version doesn't have the blue inside an element with 0.9 opacity, hence the change in colour.

I've rejigged the SVGs in the above patch (and also taken out some redundant fill-rule="nonzero"s, because that's the default). Looks the same now.

Thanks @Samwilson!

Is this ready to go?

The patch is ready for review: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TemplateWizard/+/464090

Change 464090 merged by jenkins-bot:
[mediawiki/extensions/TemplateWizard@master] Add BetaFeatures support

https://gerrit.wikimedia.org/r/464090

The above mentioned patch is merged - anything else left?

Needs a mild QA review once it's out on all projects.

It looks like the new Beta Feature code is on Test Wikipedia now, but TemplateWizard isn't showing up in the Beta Features there. It probably needs to be added to that weird Beta Features whitelist in the configs.

Change 468483 had a related patch set uploaded (by Kaldari; owner: Kaldari):
[operations/mediawiki-config@master] Adding TemplateWizard to Beta Features whitelist

https://gerrit.wikimedia.org/r/468483

FWIW, the config documentation says that we need to get either @greg or @Jdforrester-WMF to approve adding this to the whitelist. I've added both of them as reviewers for the config change patch. Greg suggested we add TemplateWizard to https://www.mediawiki.org/wiki/Beta_Features/New_Features, although no one has used that page for last two years. My suggestion is to ping James when he gets back from the RI offsite on Monday and see if he'll just +1 the config change, and then schedule it for a SWAT deployment next week. (Note that I will be on vacation that week.)

Hey, looks fine, though "Help:Extension:TemplateWizard" and "Help talk:Extension:TemplateWizard" are a tad ugly as titles. :-) +1ed.

Change 468483 merged by jenkins-bot:
[operations/mediawiki-config@master] Adding TemplateWizard to Beta Features whitelist

https://gerrit.wikimedia.org/r/468483

Mentioned in SAL (#wikimedia-operations) [2018-10-22T18:31:37Z] <jforrester@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT Add TemplateWizard to the BF allow list T205290 (duration: 00m 48s)