Page MenuHomePhabricator

Fix issues found by flake8
Closed, ResolvedPublic

Description

Commons Mass Description contains some lint errors catched by flake8 (the list is on the bottom of the task) that are currently ignored, see https://github.com/wikimedia/labs-tools-commons-mass-description/blob/master/tox.ini.

How to fix an error

(all paths here are from the root of the repository)

  1. Choose an error from the list below
  2. Delete the error and its comment from /tox.ini
  3. Run tox -e lint to run only lint and see where the error is
  4. Fix the error reported by the command until the command from step 3 reports no errors.

Errors

$ tox -e lint | grep '^\.' | sed 's/: /@/g' | cut -d @ -f 2 | sed 's/^ //g;s/too long.*$/too long/g;s/undefined name .*$/undefined name "*"/g' | sort | uniq -c | sort -k1,1nr -k2
     23 E501 line too long

Event Timeline

Urbanecm renamed this task from Clean ingore section of flake8 settings in Commons Mass Description to Fix issues found by flake8.Sep 28 2018, 9:31 PM

Change 470622 had a related patch set uploaded (by Rafidaslam; owner: Rafid Aslam):
[labs/tools/commons-mass-description@master] Fix flake8 E122 violations

https://gerrit.wikimedia.org/r/470622

Change 470622 merged by jenkins-bot:
[labs/tools/commons-mass-description@master] Fix flake8 E122 violations

https://gerrit.wikimedia.org/r/470622

Change 471505 had a related patch set uploaded (by Pipix; owner: Pipix):
[labs/tools/commons-mass-description@master] Fix Flake8 Violations

https://gerrit.wikimedia.org/r/471505

Change 471505 merged by jenkins-bot:
[labs/tools/commons-mass-description@master] Fix Flake8 Violations

https://gerrit.wikimedia.org/r/471505

Change 471561 had a related patch set uploaded (by Nathan fraignt; owner: Nathan fraignt):
[labs/tools/commons-mass-description@master] Fix Flake8 E501

https://gerrit.wikimedia.org/r/471561

Change 471561 merged by jenkins-bot:
[labs/tools/commons-mass-description@master] Fix Flake8 E501

https://gerrit.wikimedia.org/r/471561