Page MenuHomePhabricator
Create Task
Maniphest T205324

[wmf.22] AfC - Sort option 'Created date(newest)' displayed for default/reload
Closed, ResolvedPublic
Actions

Description

Credit to @MMiller_WMF - there are two problems with sort order filter options.

(1) The result set for the default filter selection - 'Awaiting for review' + 'Submitted date (oldest)') is loaded correctly but the sort order filter 'Created date (newest)' option will be displayed instead of 'Submitted date (oldest)'.

(2) Select any combination of filters - reload the page (the browser reload) - the sort order becomes 'Created date (newest)', but the result set is still for the previous sort order selection.

(3) (betalabs specific) Reloading AfC page will load NPP page.

Details

SubjectRepoBranchLines +/-
Ensure a valid afc sort option is selectedmediawiki/extensions/PageTriagewmf/1.32.0-wmf.23+27 -30
Ensure a valid afc sort option is selectedmediawiki/extensions/PageTriagemaster+27 -30
Customize query in gerrit

Related Objects
Search...

Event Timeline

Etonkovidova created this task.Sep 24 2018, 7:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2018, 7:06 PM
MMiller_WMF added a parent task: T203184: Deploy PageTriage AfC to production.Sep 24 2018, 8:13 PM
JTannerWMF moved this task from Inbox to Needs Discussion on the Growth-Team board.Sep 24 2018, 8:58 PM
SBisson removed a parent task: T203184: Deploy PageTriage AfC to production.Sep 25 2018, 10:23 AM
MMiller_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Sep 25 2018, 5:37 PM
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 25 2018, 5:38 PM
MMiller_WMF added a parent task: T193782: [EPIC] Prioritization tools for AfC and NPP.Sep 25 2018, 7:09 PM
SBisson claimed this task.Sep 26 2018, 11:01 AM
SBisson moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot subscribed.Sep 27 2018, 2:09 PM

Change 463269 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/PageTriage@master] Ensure a valid afc sort option is selected

https://gerrit.wikimedia.org/r/463269

gerritbot added a project: Patch-For-Review.Sep 27 2018, 2:09 PM
SBisson moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 27 2018, 2:23 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 28 2018, 6:19 PM
gerritbot added a comment.Sep 28 2018, 6:25 PM

Change 463269 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Ensure a valid afc sort option is selected

https://gerrit.wikimedia.org/r/463269

Etonkovidova added a comment.Sep 28 2018, 8:18 PM

Checked the fix in betalabs - all is fine.

The following issue is outside the scope of this task.

(3) (betalabs specific) Reloading AfC page will load NPP page.

Etonkovidova moved this task from QA to Design Review on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 28 2018, 8:18 PM
gerritbot added a comment.Sep 30 2018, 5:22 PM

Change 463680 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.23] Ensure a valid afc sort option is selected

https://gerrit.wikimedia.org/r/463680

gerritbot added a comment.Oct 1 2018, 6:07 PM

Change 463680 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.23] Ensure a valid afc sort option is selected

https://gerrit.wikimedia.org/r/463680

Stashbot subscribed.Oct 1 2018, 6:17 PM

Mentioned in SAL (#wikimedia-operations) [2018-10-01T18:17:48Z] <catrope@deploy1001> Synchronized php-1.32.0-wmf.23/extensions/PageTriage/: Ensure valid AFC option is selected (T205324, T205168); hide copyvio behind a global var and URL param (duration: 00m 57s)

Stashbot mentioned this in T205168: AfC: clicking 'Set filters' link will automatically change the sorting option to 'Created date (newest)' .Oct 1 2018, 6:17 PM
MMiller_WMF closed this task as Resolved.Oct 1 2018, 6:41 PM
MMiller_WMF moved this task from Design Review to Epics In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

This change was SWATed in this morning. I tried it in English Wikipedia and it works correctly. Thanks!

• Petar.petkovic removed a project: Patch-For-Review.Oct 6 2018, 2:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL