Page MenuHomePhabricator
Create Task
Maniphest T205334

Identify and remove dead code
Closed, ResolvedPublic
Actions

Description

No need to port code that is no longer useful and needed.

Details

ProjectBranchLines +/-Subject
mediawiki/services/parsoidmaster+0 -87Remove dead code
mediawiki/services/parsoidmaster+0 -17Remove dead code
mediawiki/services/parsoidmaster+0 -26Remove dead code
mediawiki/services/parsoidmaster+0 -39Remove some dead code from Util.js
mediawiki/services/parsoidmaster+0 -242Remove unused token toString and associated unused (tracing) code
Customize query in gerrit

Related Objects

Event Timeline

ssastry created this task.Sep 24 2018, 8:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2018, 8:28 PM
ssastry triaged this task as Low priority.Sep 24 2018, 8:28 PM
ssastry moved this task from Backlog to Post-Port Work on the Parsoid-PHP board.
Aklapper added a project: Technical-Debt.Sep 24 2018, 8:30 PM
gerritbot added a subscriber: gerritbot.Sep 24 2018, 9:09 PM

Change 462576 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Remove unused token toString and associated unused (tracing) code

https://gerrit.wikimedia.org/r/462576

gerritbot added a project: Patch-For-Review.Sep 24 2018, 9:09 PM
gerritbot added a comment.Sep 24 2018, 9:22 PM

Change 462576 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Remove unused token toString and associated unused (tracing) code

https://gerrit.wikimedia.org/r/462576

ssastry removed a project: Patch-For-Review.Sep 24 2018, 9:27 PM
gerritbot added a comment.Sep 25 2018, 7:53 PM

Change 462805 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Remove some dead code from Util.js

https://gerrit.wikimedia.org/r/462805

gerritbot added a project: Patch-For-Review.Sep 25 2018, 7:54 PM
Stashbot mentioned this in T163438: VisualEditor broken on wikitech when codfw is primary: "Error loading data from server: apierror-visualeditor-docserver-http: HTTP 500.".Sep 27 2018, 6:14 PM
Stashbot mentioned this in T108776: Parsoid on wikitech fails.
Stashbot added a subscriber: Stashbot.

Mentioned in SAL (#wikimedia-operations) [2018-09-27T18:12:14Z] <arlolra> Updated Parsoid to rGPARaf3a920c97fd (T198511, T163438, T108776, T205334, T114413)

Stashbot mentioned this in T114413: Support various conversions in Parsoid's pb2pb endpoint.Sep 27 2018, 6:14 PM
Arlolra mentioned this in T198511: VisualEditor losing Media: links.Sep 27 2018, 7:21 PM
gerritbot added a comment.Sep 28 2018, 8:24 PM

Change 462805 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Remove some dead code from Util.js

https://gerrit.wikimedia.org/r/462805

ssastry removed a project: Patch-For-Review.Sep 28 2018, 10:08 PM
gerritbot added a comment.Oct 30 2018, 9:55 PM

Change 470712 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Remove dead code

https://gerrit.wikimedia.org/r/470712

gerritbot added a project: Patch-For-Review.Oct 30 2018, 9:55 PM
gerritbot added a comment.Oct 30 2018, 11:02 PM

Change 470712 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Remove dead code

https://gerrit.wikimedia.org/r/470712

gerritbot added a comment.Oct 31 2018, 3:54 AM

Change 470746 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Remove dead code

https://gerrit.wikimedia.org/r/470746

gerritbot added a comment.Oct 31 2018, 2:21 PM

Change 470746 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Remove dead code

https://gerrit.wikimedia.org/r/470746

gerritbot added a comment.Oct 31 2018, 6:19 PM

Change 470884 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Remove dead code

https://gerrit.wikimedia.org/r/470884

gerritbot added a comment.Oct 31 2018, 7:44 PM

Change 470884 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Remove dead code

https://gerrit.wikimedia.org/r/470884

Stashbot added a comment.Nov 5 2018, 9:49 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-05T21:49:08Z] <arlolra> Updated Parsoid to 8ed698b (T205334, T208360)

Stashbot mentioned this in T208360: Split Utils and DOMUtils into smaller chunks based on functionality.Nov 5 2018, 9:49 PM
Arlolra removed a project: Patch-For-Review.Nov 5 2018, 10:13 PM
ssastry closed this task as Resolved.Dec 4 2018, 9:23 PM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL