Page MenuHomePhabricator
Create Task
Maniphest T205335

Remove console.* statements
Closed, ResolvedPublic
Actions

Description

We shouldn't have bare console.log statements in the codebase -- all legit uses should probably go through the logger. The remaining ones might either be commented out statements, debugging code, or uses that should be using the logger.

Details

SubjectRepoBranchLines +/-
Remove console.log statements from lib/ that don't belongmediawiki/services/parsoidmaster+1 -25
Customize query in gerrit

Event Timeline

ssastry created this task.Sep 24 2018, 8:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2018, 8:29 PM
ssastry triaged this task as Low priority.Sep 24 2018, 8:30 PM
ssastry moved this task from Backlog to Post-Port Work on the Parsoid-PHP board.
gerritbot subscribed.Nov 9 2018, 8:18 PM

Change 472716 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Remove console.log statements from lib/ that don't belong

https://gerrit.wikimedia.org/r/472716

gerritbot added a project: Patch-For-Review.Nov 9 2018, 8:18 PM
gerritbot added a comment.Nov 9 2018, 10:24 PM

Change 472716 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Remove console.log statements from lib/ that don't belong

https://gerrit.wikimedia.org/r/472716

ssastry closed this task as Resolved.Nov 9 2018, 10:50 PM
ssastry claimed this task.
Aklapper removed a project: Patch-For-Review.Apr 10 2020, 9:43 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL