Page MenuHomePhabricator
Create Task
Maniphest T205338

Extract and use a DOMHandler interface (API) for HTML -> wt handlers defined on DOM nodes
Closed, ResolvedPublic
Actions

Description

  • DOMHandlers for HTML -> wt currently use a more-or-less uniform interface to define handlers for various DOM node types
  • This can be extracted into a parent class / interface

Not only is this going to be good documentation, this also makes the porting simpler and more performant.

Details

ProjectBranchLines +/-Subject
mediawiki/services/parsoidmaster+4 K -3 KCreate a DOMHandler class to ease porting
mediawiki/services/parsoidmaster+1 K -1 KStep two, make a SepNls class
mediawiki/services/parsoidmaster+292 -52WIP: Experimental simplification of SyncTTM and handlers
mediawiki/services/parsoidmaster+40 K -9 KWIP: Add back generateTest, traceTime support and update transformTests.js
mediawiki/services/parsoidmaster+41 -380WIP: Purge old sync handler related code
Customize query in gerrit

Related Objects

Event Timeline

ssastry created this task.Sep 24 2018, 8:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2018, 8:37 PM
ssastry triaged this task as Medium priority.Sep 24 2018, 8:37 PM
ssastry moved this task from Backlog to Post-Port Work on the Parsoid-PHP board.
gerritbot added a subscriber: gerritbot.Dec 14 2018, 7:14 PM

Change 479742 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] WIP: Experimental simplification of SyncTTM and handlers

https://gerrit.wikimedia.org/r/479742

gerritbot added a project: Patch-For-Review.Dec 14 2018, 7:14 PM
gerritbot added a comment.Dec 24 2018, 6:46 PM

Change 481305 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] WIP: Purge old sync handler related code

https://gerrit.wikimedia.org/r/481305

gerritbot added a comment.Dec 24 2018, 6:46 PM

Change 481306 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] WIP: Add back generateTest, traceTime support and update transformTests.js

https://gerrit.wikimedia.org/r/481306

ssastry added a comment.Jan 7 2019, 10:58 PM

Oops .. I used the wrong task id on those patches

ssastry removed a project: Patch-For-Review.Jan 7 2019, 10:58 PM
gerritbot added a comment.Jan 9 2019, 3:50 PM

Change 479742 abandoned by Subramanya Sastry:
WIP: Experimental simplification of SyncTTM and handlers

Reason:
Squashed the three separate patches into one

https://gerrit.wikimedia.org/r/479742

gerritbot added a comment.Jan 9 2019, 3:50 PM

Change 481305 abandoned by Subramanya Sastry:
WIP: Purge old sync handler related code

Reason:
Squashed the three separate patches into one

https://gerrit.wikimedia.org/r/481305

gerritbot added a comment.Jan 9 2019, 3:50 PM

Change 481306 abandoned by Subramanya Sastry:
WIP: Add back generateTest, traceTime support and update transformTests.js

Reason:
Squashed the three separate patches into one

https://gerrit.wikimedia.org/r/481306

Arlolra claimed this task.Apr 24 2019, 6:40 PM
gerritbot added a comment.Apr 24 2019, 8:54 PM

Change 506318 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] [WIP] DOMHandler

https://gerrit.wikimedia.org/r/506318

gerritbot added a project: Patch-For-Review.Apr 24 2019, 8:54 PM
Tgr added a subscriber: Tgr.Apr 25 2019, 12:01 AM

Also in PHP WikitextSerializer.getDOMHandler should be extracted and turned into some kind of factory object, don't know if it makes sense to do that on the JS side as well.

gerritbot added a comment.Apr 25 2019, 9:41 PM

Change 506554 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] [WIP] Step two, make a SepNls class

https://gerrit.wikimedia.org/r/506554

gerritbot added a comment.Apr 26 2019, 3:08 PM

Change 506554 abandoned by Arlolra:
Step two, make a SepNls class

Reason:
Squashed into https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/ /506318

https://gerrit.wikimedia.org/r/506554

gerritbot added a comment.Apr 26 2019, 10:51 PM

Change 506318 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Create a DOMHandler class to ease porting

https://gerrit.wikimedia.org/r/506318

Arlolra closed this task as Resolved.Apr 26 2019, 11:05 PM
Stashbot mentioned this in T106578: Sanitizer entity restrictions should match HTML5.Apr 29 2019, 8:40 PM
Stashbot mentioned this in T113194: MediaWiki fails to parse – (en dash).

Mentioned in SAL (#wikimedia-operations) [2019-04-29T20:40:46Z] <arlolra> Updated Parsoid to c9dab9d (T106578, T113194, T205338, T219072, T219938, T221384, T219943)

Stashbot mentioned this in T219072: Extend JS/PHP hybrid testing to other Parsoid components.Apr 29 2019, 8:40 PM
Stashbot mentioned this in T219938: Port HTML5Treebuilder.
Stashbot mentioned this in T221384: Wikipeg cache is unsafe when rule variables are set to null/undefined.
Stashbot mentioned this in T219943: Create a composer library for wikipeg.
Aklapper removed a project: Patch-For-Review.Apr 10 2020, 9:43 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL