Per https://gerrit.wikimedia.org/r/c/mediawiki/core/+/435822 :
It is assumed that empty ar_user_text and rev_user_text fields will be fixed during migration to the new actor based database schema.
Once that's done, the patch can be reverted to make MediaWiki fail hard on database inconsistencies (or not; in the longer term, those fields will be removed anyway).
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | daniel | T161671 Compacting the revision table | |||
| Resolved | None | T227047 Complete actor table and comment table migration | |||
| Open | None | T28816 RenameUser should log out target user to prevent unwanted recreation of old username | |||
| Open | None | T25135 blocking user is not updated after rename | |||
| Open | None | T167246 Refactor "user" & "user_text" fields into "actor" reference table | |||
| Open | None | T205353 Clean up empty ar_user_text and rev_user_text fields |
Not sure to what extend this happened, but neither ar_user_text nor rev_user_text do exist anymore. So I guess this can be resolved?
We still have this code block and this one for handling a missing username. The resolution would be to drop those (and use ActorStore::newActorFromRow() instead of ActorStore::newActorFromRowFields(), I think? But I assume we'd have to wait until pre-actor-migration DB schema goes out of B/C support.
In the sense of trying to recover the user from the *_user field when *_user_text is broken, I think that happaned as part of the migration script. If it didn't, it's too late now, anyway.
I honestly don't think it's a blocker for calling T167246: Refactor "user" & "user_text" fields into "actor" reference table done. It's a deprecation and clean up after the fact but actor table migration is done.