x86/mce: Factor out and deprecate the /dev/mcelog driver Move all code relating to /dev/mcelog to a separate source file. /dev/mcelog driver can now operate from the machine check notifier with lowest prio. Signed-off-by: Tony Luck <firstname.lastname@example.org> [ Move the mce_helper and trigger functionality behind CONFIG_X86_MCELOG_LEGACY. ] Signed-off-by: Borislav Petkov <email@example.com> Cc: Linus Torvalds <firstname.lastname@example.org> Cc: Peter Zijlstra <email@example.com> Cc: Thomas Gleixner <firstname.lastname@example.org> Cc: linux-edac <email@example.com> Link: http://firstname.lastname@example.org [ Renamed CONFIG_X86_MCELOG to CONFIG_X86_MCELOG_LEGACY. ] Signed-off-by: Ingo Molnar <email@example.com>
Side-effect of trying to run mcelog on kernel >= 4.12:
---------- Forwarded message ---------- From: Cron Daemon <firstname.lastname@example.org> Date: Mon, Sep 24, 2018 at 6:23 PM Subject: Cron <root@backup2001> /usr/local/sbin/wmf-auto-restart -s mcelog To: email@example.com Traceback (most recent call last): File "/usr/local/sbin/wmf-auto-restart", line 142, in <module> sys.exit(main()) File "/usr/local/sbin/wmf-auto-restart", line 138, in main return check_restart(args.servicename, args.dryrun) File "/usr/local/sbin/wmf-auto-restart", line 59, in check_restart pid_query = subprocess.check_output(["/bin/pidof", service_name], universal_newlines=True) File "/usr/lib/python3.5/subprocess.py", line 316, in check_output **kwargs).stdout File "/usr/lib/python3.5/subprocess.py", line 398, in run output=stdout, stderr=stderr) subprocess.CalledProcessError: Command '['/bin/pidof', 'mcelog']' returned non-zero exit status 1
Due to kernel upgrade in T196477
I have created https://phabricator.wikimedia.org/T205366 to migrate away from mcelog.
In principle we could make the installation of mcelog conditional on the kernel version, but backup2001 was mostly installed with 4.14 for some hardware tests, we'll not use that kernel in production. Once we have the replacement parts available it will get reimaged with stretch and the regular 4.9 kernel, so I'll close this bug. But the report has been very useful as it unveiled the migration issue for mcelog, thanks!