⚓ T205382 Remove code related to no-anonymous-editing mode of MobileFrontend ($wgMFEditorOptions['anonymousEditing'] = false;)

	Subject	Repo	Branch	Lines +/-
	Remove code related to no-anonymous-editing mode of MobileFrontend	mediawiki/skins/MinervaNeue	master	+9 -462
	Remove option to disable anonymous editing	mediawiki/extensions/MobileFrontend	master	+1 -11

Status	Assigned	Task
Open	None	T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
Declined	None	T144571 Mobile Media Viewer violates user settings
Open	Jdlrobson	T65504 Consolidate code for MediaViewer across desktop and mobile
Declined	None	T162210 [EPIC] Upstream MobileFrontend components to core and other extensions (tracking)
Duplicate	Jdlrobson	T66316 [EPIC] Move Nearby code to more suitable extension
Open	None	T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
Open	None	T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
Declined	None	T96202 [EPIC] Rewrite MobileFrontend frontend code in OOUI
Duplicate	None	T101462 [EPIC] Merge OOJS UI library and Mobile unnamed library.
Open	None	T96186 [EPIC] Move VisualEditor code from MobileFrontend to VisualEditor
Open	None	T106267 mobile phone wikitext editor should have edit toolbar
Open	None	T106266 Provide a "signature" button in the mobile wikitext editor
Open	None	T171974 Improve and consolidate our unified editing platform so that it's great on all devices
Open	None	T159971 Provide the VE wikitext editing mode as the mobile wikitext editor
Resolved	matmarex	T198765 Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop)
Resolved	ovasileva	T205382 Remove code related to no-anonymous-editing mode of MobileFrontend ($wgMFEditorOptions['anonymousEditing'] = false;)

matmarex created this task.Sep 25 2018, 8:45 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2018, 8:45 AM

I'd be happy to work on this if someone confirms that you want it removed. :)

matmarex mentioned this in T205351: Anonymous CTAs for section edit links are broken for 3rd parties.Sep 25 2018, 8:49 AM

@ovasileva thoughts on removing this code?

In T205382#4615164, @Jdlrobson wrote:

@ovasileva thoughts on removing this code?

No objections from my end.

@matmarex if we make this change will it honor wgPermissions instead ? If not, can it be made to?

Jdlrobson updated the task description. (Show Details)Oct 3 2018, 10:25 PM

Jdlrobson triaged this task as Medium priority.Oct 5 2018, 4:25 PM

Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.

Jdlrobson added a project: patch-welcome.

Jdlrobson updated the task description. (Show Details)

@Jdlrobson I'm not sure what you mean. But as far as I know, the mobile editor already respects the normal user permissions.

matmarex claimed this task.Oct 5 2018, 10:47 PM

Change 464925 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/MinervaNeue@master] Remove code related to no-anonymous-editing mode of MobileFrontend

https://gerrit.wikimedia.org/r/464925

Change 464926 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] Remove option to disable anonymous editing

https://gerrit.wikimedia.org/r/464926

I'd like us to commit to reviewing Bartosz's patches within the next week. Moving to the sprint board for visibility.

Jdlrobson moved this task from To Do to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 10 2018, 7:04 PM

gerritbot mentioned this in T198765: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop).Oct 10 2018, 10:04 PM

Change 464925 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove code related to no-anonymous-editing mode of MobileFrontend

https://gerrit.wikimedia.org/r/464925

Change 464926 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove option to disable anonymous editing

https://gerrit.wikimedia.org/r/464926

Jdlrobson moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 11 2018, 8:32 PM

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 11 2018, 9:01 PM

Jdlrobson updated the task description. (Show Details)Oct 11 2018, 11:03 PM

Jdlrobson reassigned this task from matmarex to Ryasmeen.Oct 11 2018, 11:08 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Product-QA.

matmarex added a parent task: T198765: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop).Oct 12 2018, 3:37 PM

@Jdlrobson & @ovasileva I am having some trouble on Beta right now. I am unable to edit either logged in or out. It is hanging on this spinner.

matmarex updated the task description. (Show Details)Oct 18 2018, 8:05 PM

@ABorbaWMF, BC seems to be working at the moment for me https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:History/User:Teststephen

Did some exploratory testing, nothing seems broken to me for this change.

To confirm: I can edit both as a logged in user and as an anonymous user using the edit icon for the article but not with section edit icon.

Ryasmeen moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 23 2018, 10:12 PM

o confirm: I can edit both as a logged in user and as an anonymous user using the edit icon for the article but not with section edit icon.

@Ryasmeen I can edit with the section edit icon on https://en.m.wikipedia.beta.wmflabs.org/wiki/Echo_test_page_158360831278326872513083237944042439519#

In T205382#4690351, @Jdlrobson wrote:

o confirm: I can edit both as a logged in user and as an anonymous user using the edit icon for the article but not with section edit icon.

@Ryasmeen I can edit with the section edit icon on https://en.m.wikipedia.beta.wmflabs.org/wiki/Echo_test_page_158360831278326872513083237944042439519#

okay yeah for that page it's working for me, but I was testing on the test page mentioned under QA steps:
https://en.wikipedia.beta.wmflabs.org/wiki/Transcluded_page

For that one, it's not opening the editor for me.

Sorry of all the random page I could have picked.. that was a terrible example to pick :) (T198011)

In T205382#4690388, @Jdlrobson wrote:

Sorry of all the random page I could have picked.. that was a terrible example to pick :) (T198011)

hah! :) alright then, this one is good to go.

• Niedzielski removed Ryasmeen as the assignee of this task.Oct 24 2018, 5:12 PM

• Niedzielski added a subscriber: Ryasmeen.

Looks good, thanks all!

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 24 2018, 5:20 PM

ovasileva updated the task description. (Show Details)Oct 24 2018, 5:21 PM

Remove code related to no-anonymous-editing mode of MobileFrontend ($wgMFEditorOptions['anonymousEditing'] = false;)
Closed, ResolvedPublic
Actions

Description

acceptance criteria

QA steps

Details

Related Objects
Search...

Event Timeline

	F26624070: image.png
	Oct 18 2018, 7:24 PM

	F26624080: image.png
	Oct 18 2018, 7:24 PM

	F26624075: image.png
	Oct 18 2018, 7:24 PM

Remove code related to no-anonymous-editing mode of MobileFrontend ($wgMFEditorOptions['anonymousEditing'] = false;)Closed, ResolvedPublicActions