Now that we have slots I suspect that it's redundant, and perhaps the code from T177023 needs to be removed
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Stop writing content to page_props, we don't use it | mediawiki/extensions/WikibaseMediaInfo | master | +0 -556 |
Related Objects
Related Objects
- Mentioned In
- T208517: Should Wikibase add a property to the page response object that indicates the embedded entities?
rEWBIbcd8e288e465: Stop writing content to page_props, we don't use it
rEWBI47b2e2b450e3: Stop writing content to page_props, we don't use it
rEWBI8dfc557519d9: Stop writing content to page_props, we don't use it
T208545: Beta Commons: Upload with File Caption tries 20 times(!) to get the entity ID to write, but fails - Mentioned Here
- T177023: Add a page_props entry to new file pages linking to the associated MediaInfo entity
Event Timeline
Comment Actions
The associated media info page (or, id) is 'M<pageId>'.
IIRC, the page_prop was added so that it would be possible to reliably find the associated mediainfo id for a file page, without having to duplicate/hard-code that logic in another client.
I don't think we still need that page_prop once it's in the same slot as the file page. I haven't checked, but I assume there's already a way to find the IDs of things in a page's slots.
I'm pretty sure UploadWizard's caption submission currently uses that page_prop, though, so we should make sure to change that before we remove the page_prop.
Comment Actions
Change 477630 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] Stop writing content to page_props, we don't use it
Comment Actions
Change 477630 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Stop writing content to page_props, we don't use it