Maniphest T205431

Keep frames of text boxes also on Chrome
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

The edit behavior of the text boxes should not have side effects. On Chrome, however, boxes tend to get grey outlines.

Example of view in Chrome
In the first three rows of text boxes, the edit button was clicked. In the last row, it wasn't:

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/TwoColConflict	master	+17 -17	Fix CSS for Chrome on MacOS and Firefox with dark color scheme
	mediawiki/extensions/TwoColConflict	master	+4 -4	Fix CSS for Chrome on MacOS and Firefox with dark color scheme

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Duplicate	None	T86785 Excessive quantity of edits conflict in a busy project page
Open	None	T113004 Make it easy to fork, branch, and merge pages (or more)
Open	None	T72163 Edit conflicts (tracking)
Open	None	T139601 Better solutions to edit conflicts (#1)
Resolved	WMDE-Fisch	T195711 Make v2 of TwoColConflict: line based edit conflict handling
Resolved	Andrew-WMDE	T195721 Support JS enhanced editing on the merge view (No. 7)
Resolved	WMDE-Fisch	T203144 Show wikitext editor when clicking on enabled edit buttons
Resolved	jkroll	T205431 Keep frames of text boxes also on Chrome

Event Timeline

Lea_WMDE triaged this task as Medium priority.Sep 25 2018, 1:17 PM

Lea_WMDE created this task.

Lea_WMDE moved this task from Backlog to Tickets in sprint on the Two-Column-Edit-Conflict-Merge board.Sep 25 2018, 1:24 PM

WMDE-Fisch removed WMDE-Fisch as the assignee of this task.Sep 27 2018, 4:16 PM

I don't have Chrome installed, but I found "interesting" results with other browsers:

In Chromium 69.0.3497.81, nothing is greyed out. Everything looks fine to me.
In Opera 54.0.2952.64 (yes that still exists!) everything looks fine as well
In Firefox 62.0, the text boxes keep their color but the text itself is greyed out after clicking the edit button. In the attached screenshot the edit button was clicked in the first two rows, but not the last row.

WMDE-Fisch assigned this task to jkroll.Oct 2 2018, 1:55 PM

WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-09-25 board.

Change 463973 had a related patch set uploaded (by Jkroll; owner: Jkroll):
[mediawiki/extensions/TwoColConflict@master] Fix CSS for Chrome on MacOS and Firefox with dark color scheme

https://gerrit.wikimedia.org/r/463973

gerritbot added a project: Patch-For-Review.Oct 2 2018, 4:07 PM

jkroll mentioned this in rESCC8565895b87cc: Fix CSS for Chrome on MacOS and Firefox with dark color scheme.Oct 2 2018, 4:08 PM

jkroll mentioned this in rESCCc9c4b06c480b: Fix CSS for Chrome on MacOS and Firefox with dark color scheme.Oct 5 2018, 10:19 AM

Change 464793 had a related patch set uploaded (by Jkroll; owner: Jkroll):
[mediawiki/extensions/TwoColConflict@master] Fix CSS for Chrome on MacOS and Firefox with dark color scheme

https://gerrit.wikimedia.org/r/464793

jkroll mentioned this in rESCC36fd413eb850: Fix CSS for Chrome on MacOS and Firefox with dark color scheme.Oct 5 2018, 10:59 AM

jkroll mentioned this in rESCCceb1f872e73d: Fix CSS for Chrome on MacOS and Firefox with dark color scheme.

Change 463973 abandoned by Jkroll:
Fix CSS for Chrome on MacOS and Firefox with dark color scheme

https://gerrit.wikimedia.org/r/463973

jkroll mentioned this in rESCCf287f46f72a3: Fix CSS for Chrome on MacOS and Firefox with dark color scheme.Oct 5 2018, 11:56 AM

jkroll mentioned this in rESCC7f33549fd1ea: Fix CSS for Chrome on MacOS and Firefox with dark color scheme.Oct 5 2018, 12:14 PM

jkroll mentioned this in rESCC1c7652366fdf: Fix CSS for Chrome on MacOS and Firefox with dark color scheme.Oct 5 2018, 1:17 PM

jkroll mentioned this in rESCCdbe5a55120d5: Fix CSS for Chrome on MacOS and Firefox with dark color scheme.Oct 8 2018, 4:23 PM

thiemowmde mentioned this in T206526: Reduce copy-pasted <textarea> CSS to a maintainable subset.Oct 9 2018, 11:06 AM

WMDE-Fisch added a project: WMDE-QWERTY-Sprint-2018-10-09.Oct 9 2018, 1:06 PM

WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-10-09 board.